This commit is contained in:
Eloy Lafuente (stronk7) 2017-01-11 02:42:29 +01:00
commit 777361983c
99 changed files with 562 additions and 543 deletions

20
.gherkin-lintrc Normal file
View file

@ -0,0 +1,20 @@
{
"indentation": ["on",{
"Feature": 0,
"Background": 2,
"Scenario": 2,
"Step": 4,
"given": 4,
"and": 4
}],
"no-dupe-feature-names": "on",
"no-dupe-scenario-names": "off",
"no-empty-file": "on",
"no-files-without-scenarios": "on",
"no-multiple-empty-lines": "on",
"no-partially-commented-tag-lines": "on",
"no-trailing-spaces": "on",
"no-unamed-features": "on",
"no-unamed-scenarios": "on",
"no-scenario-outlines-without-examples": "on"
}

View file

@ -106,7 +106,6 @@ module.exports = function(grunt) {
return libs;
};
// Project configuration.
grunt.initConfig({
eslint: {
@ -171,6 +170,10 @@ module.exports = function(grunt) {
files: ['**/yui/src/**/*.js'],
tasks: ['yui']
},
gherkinlint: {
files: ['**/tests/behat/*.feature'],
tasks: ['gherkinlint']
}
},
shifter: {
options: {
@ -178,6 +181,11 @@ module.exports = function(grunt) {
paths: [cwd]
}
},
gherkinlint: {
options: {
files: ['**/tests/behat/*.feature'],
}
},
stylelint: {
less: {
options: {
@ -318,6 +326,22 @@ module.exports = function(grunt) {
}, done);
};
tasks.gherkinlint = function() {
var done = this.async(),
options = grunt.config('gherkinlint.options');
var args = grunt.file.expand(options.files);
args.unshift(path.normalize(__dirname + '/node_modules/.bin/gherkin-lint'));
grunt.util.spawn({
cmd: 'node',
args: args,
opts: {stdio: 'inherit', env: process.env}
}, function(error, result, code) {
// Propagate the exit code.
done(code);
});
};
tasks.startup = function() {
// Are we in a YUI directory?
if (path.basename(path.resolve(cwd, '../../')) == 'yui') {
@ -329,6 +353,7 @@ module.exports = function(grunt) {
// Run them all!.
grunt.task.run('css');
grunt.task.run('js');
grunt.task.run('gherkinlint');
}
};
@ -343,6 +368,7 @@ module.exports = function(grunt) {
grunt.config('uglify.amd.files', [{expand: true, src: files, rename: uglifyRename}]);
grunt.config('shifter.options.paths', files);
grunt.config('stylelint.less.src', files);
grunt.config('gherkinlint.options.files', files);
changedFiles = Object.create(null);
}, 200);
@ -360,6 +386,7 @@ module.exports = function(grunt) {
// Register JS tasks.
grunt.registerTask('shifter', 'Run Shifter against the current directory', tasks.shifter);
grunt.registerTask('gherkinlint', 'Run gherkinlint against the current directory', tasks.gherkinlint);
grunt.registerTask('ignorefiles', 'Generate ignore files for linters', tasks.ignorefiles);
grunt.registerTask('yui', ['eslint:yui', 'shifter']);
grunt.registerTask('amd', ['eslint:amd', 'uglify']);

View file

@ -125,7 +125,6 @@ Feature: Verify that all form fields values can be get and set
And I navigate to "Edit settings" node in "Course administration"
And the field "Course ID number" matches value "Course id number"
Scenario: with JS disabled all form fields getters and setters works as expected
@javascript

View file

@ -26,4 +26,3 @@ Feature: List the system steps definitions
Given I set the field "Contains" to "homepage"
When I press "Filter"
Then I should see "Opens Moodle homepage."

View file

@ -4,7 +4,6 @@ Feature: Manage language packs
As an administrator
I need to be able to add, update and remove language packs
Background:
Given remote langimport tests are enabled

View file

@ -78,4 +78,3 @@ Feature: Manage evidence of prior learning
Then I should see "List of evidence"
And I should see "Evidence-6"
And I should not see "Evidence-5"

View file

@ -357,4 +357,3 @@ Feature: Award badges
When I press "Revoke badge"
And I follow "Course Badge"
Then I should see "Recipients (0)"

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block doesn't displays student scores for unconfigured block
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block doesn't display student scores for unsupported activity
In order to be display student scores
As a user
I need to properly configure the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays student high scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores as scales
Feature: The activity results block displays students high scores in group as scales
In order to be display student scores as scales
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores as scales
Feature: The activity results block displays student in group high scores as scales
In order to be display student scores as scales
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays student in separate groups scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays student in visible groups scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays student low scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores as scales
Feature: The activity results block displays student low scores as scales
In order to be display student scores as scales
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores as scales
Feature: The activity results block displays students in groups low scores as scales
In order to be display student scores as scales
As a user
I need to see the activity results block
@ -146,4 +146,3 @@ Feature: The activity results block displays student scores as scales
And I should see "User" in the "Activity results" "block"
And I should see "Good" in the "Activity results" "block"
And I should see "Average" in the "Activity results" "block"

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays students in separate groups scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,5 +1,5 @@
@block @block_activity_results
Feature: The activity results block displays student scores
Feature: The activity results block displays student in visible groups low scores
In order to be display student scores
As a user
I need to see the activity results block

View file

@ -1,8 +1,8 @@
@block @block_blog_menu
Feature: Enable Block blog menu in a course
In order to enable the blog menu in a course
As a teacher
I can add blog menu block to a course
Feature: Students can use block blog menu in a course
In order students to use the blog menu in a course
As a student
I view blog menu block in a course
Background:
Given the following "users" exist:

View file

@ -1,5 +1,5 @@
@block @block_calendar_upcoming
Feature: View a site event on the dashboard
Feature: View a upcoming site event on the dashboard
In order to view a site event
As a student
I can view the event in the upcoming events block

View file

@ -52,7 +52,6 @@ Feature: Enable Block Completion in a course using manual completion by others
And I follow "More details"
And I should see "Yes" in the "Marked complete by Teacher" "table_row"
Scenario: Add the block to a the course and require multiple roles to mark a student complete.
Given I log in as "teacher1"
And I follow "Course 1"

View file

@ -91,4 +91,3 @@ Feature: View the quiz being due
And I should not see "Quiz 1B Past deadline" in the "Course overview" "block"
And I should not see "Quiz 1D Future deadline" in the "Course overview" "block"
And I should not see "Quiz 2A Future deadline" in the "Course overview" "block"

View file

@ -1,5 +1,5 @@
@block @block_html
Feature: Adding and configuring HTML blocks
Feature: Adding and configuring multiple HTML blocks
In order to have one or multiple HTML blocks on a page
As admin
I need to be able to create, configure and change HTML blocks

View file

@ -1,5 +1,5 @@
@block @block_online_users
Feature: The online users block allow you to see who is currently online
Feature: The online users block allow you to see who is currently online on dashboard
In order to use the online users block on the dashboard
As a user
I can view the online users block on my dashboard

View file

@ -1,5 +1,5 @@
@block @block_online_users
Feature: The online users block allow you to see who is currently online
Feature: The online users block allow you to see who is currently online on frontpage
In order to enable the online users block on the front page page
As an admin
I can add the online users block to the front page page

View file

@ -1,5 +1,5 @@
@block @block_private_files @_file_upload @javascript
Feature: The private files block allows users to store files privately in moodle
Feature: The private files block allows users to store files privately in moodle on activity page
In order to store a private file in moodle
As a teacher
I can upload the file to my private files area using the private files block in an activity

View file

@ -1,5 +1,5 @@
@block @block_private_files @_file_upload @javascript
Feature: The private files block allows users to store files privately in moodle
Feature: The private files block allows users to store files privately in moodle on course page
In order to store a private file in moodle
As a teacher
I can upload the file to my private files area using the private files block in a course

View file

@ -1,5 +1,5 @@
@block @block_private_files @_file_upload @javascript
Feature: The private files block allows users to store files privately in moodle
Feature: The private files block allows users to store files privately in moodle on dashboard
In order to store a private file in moodle
As a user
I can upload the file to my private files area using the private files block on the dashboard

View file

@ -1,5 +1,5 @@
@block @block_private_files @_file_upload
Feature: The private files block allows users to store files privately in moodle
Feature: The private files block allows users to store files privately in moodle on front page.
In order to store a private file in moodle
As a teacher
I can upload the file to my private files area using the private files block from the front page

View file

@ -1,5 +1,5 @@
@block @block_search_forums @mod_forum
Feature: The search forums block allows users to search for forum posts
Feature: The search forums block allows users to search for forum posts on course page
In order to search for a forum post
As a user
I can use the search forums block

View file

@ -1,5 +1,5 @@
@block @block_search_forums @mod_forum
Feature: The search forums block allows users to search for forum posts
Feature: The search forums block allows users to search for forum posts on frontpage
In order to search for a forum post
As an administrator
I can add the search forums block

View file

@ -27,7 +27,6 @@ Feature: The section links block allows users to quickly navigate around a moodl
| id_coursedisplay | Show one section per page |
And I press "Save and display"
Scenario: Add the section links block to a course.
Given I add the "Section links" block
And I turn editing mode off

View file

@ -48,4 +48,3 @@ Feature: Delete a blog entry
And I press "Cancel"
And I should see "Blog post one"
And I should see "Blog post two"

View file

@ -111,4 +111,3 @@ Feature: Perform basic calendar functionality
| Description | Wait, this event isn't that great. |
And I press "Save changes"
And I should see "Mediocre event"

View file

@ -125,4 +125,3 @@ Feature: Access visible and hidden cohorts
And the "Select members from cohort" select box should not contain "Cohort in category 2"
And the "Select members from cohort" select box should not contain "Cohort empty in category 1"
And the "Select members from cohort" select box should not contain "System empty cohort"

View file

@ -10,7 +10,6 @@ Feature: Courses can be searched for and moved in bulk.
| Science | 0 | SCI |
| English | 0 | ENG |
| Miscellaneous | 0 | MISC |
And the following "courses" exist:
| fullname | shortname | category |
| Biology Y1 | BIO1 | MISC |

View file

@ -48,4 +48,3 @@ Feature: Force group mode in a course
And I press "Save and display"
Then "//a/child::img[contains(@alt, 'No groups (forced mode)')]" "xpath_element" should not exist
And "//img[contains(@alt, 'No groups (forced mode)')]" "xpath_element" should not exist

View file

@ -4,7 +4,6 @@ Feature: Add a new custom file type
As an admin
I need to add a new custom file type
@javascript
Scenario: Add custom file type
Given the following "courses" exist:

View file

@ -4,7 +4,6 @@ Feature: Using the AJAX grading feature of Grader report to update grades and fe
As a teacher
I need to be able to update and verify grades
Background:
Given the following "courses" exist:
| fullname | shortname | category | groupmode |

View file

@ -1,5 +1,5 @@
@core_grades
Feature: Editing a grade item
Feature: Grade item validation
In order to ensure validation is provided to the teacher
As a teacher
I need to know why I can not add/edit values on the grade item form

View file

@ -1,5 +1,5 @@
@core @core_grades
Feature: We can customise the letter boundary of a course.
Feature: We can customise the letter boundary of a course in gradebook version 20160518.
In order to change the letter boundary of a course
As a teacher
I need to add assessments to the gradebook.

View file

@ -229,7 +229,6 @@ Feature: We can use natural aggregation and weights will be normalised to a tota
@javascript
Scenario: With one grade item set as extra credit, when I reset the weights for a category they return to the natural weights.
When I set the following settings for grade item "Test assignment five":
| Extra credit | 1 |
And I set the field "Override weight of Test assignment six" to "1"
@ -244,7 +243,6 @@ Feature: We can use natural aggregation and weights will be normalised to a tota
@javascript
Scenario: Overriding a grade item with a negative value results in the value being changed to zero.
When I set the field "Override weight of Test assignment five" to "1"
And I set the field "Weight of Test assignment five" to "-15"
And I press "Save changes"

View file

@ -32,4 +32,3 @@ Feature: Atto accessibility helper
# This shows the current HTML tags applied to the selected text.
# This is required because they are not always read by a screen reader.
Then I should see "UL, LI"

View file

@ -53,4 +53,3 @@ Feature: Atto align text
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "style=\"text-align:center;\""

View file

@ -20,4 +20,3 @@ Feature: Atto clear button
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should not see "<i>Pisa"

View file

@ -11,4 +11,3 @@ Feature: Atto collapse button
Then "Equation editor" "button" should be visible
And I click on "Show fewer buttons" "button"
Then "Equation editor" "button" should not be visible

View file

@ -11,4 +11,3 @@ Feature: Atto edit HTML
And I click on "Show more buttons" "button"
And I click on "HTML" "button"
Then the field "Description" matches value "<p style=\"color: blue;\">Smurf</p>"

View file

@ -24,4 +24,3 @@ Feature: Add links to Atto
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "Super cool</a>"

View file

@ -18,4 +18,3 @@ Feature: Atto strike button
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "<strike>MUA</strike>"

View file

@ -35,4 +35,3 @@ Feature: Atto subscript button
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "<sub>Submarine</sub>"

View file

@ -35,4 +35,3 @@ Feature: Atto superscript button
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "<sup>Helicopter</sup>"

View file

@ -18,4 +18,3 @@ Feature: Atto title
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "<h3>How The Rock"

View file

@ -18,4 +18,3 @@ Feature: Atto underline button
And I press "Save changes"
And I click on "Edit profile" "link" in the "region-main" "region"
Then I should see "<u>Deprecated HTML Tag</u>"

View file

@ -1,5 +1,5 @@
@core @message @javascript
Feature: Search users
Feature: Manage contacts
In order to communicate with fellow users
As a user
I need to be able to add and remove them from my contacts

View file

@ -63,4 +63,3 @@ Feature: In an assignment, teacher can view the feedback for a previous attempt.
And I wait until the page is ready
And I should see "You are editing the feedback for a previous attempt. This is attempt 1 out of 2."
And I should see "Page 1 of 3"

View file

@ -63,4 +63,3 @@ Feature: Check that the assignment grade can not be input in a wrong format.
And I set the field "Grade out of 100" to "50..6"
And I press "Save changes"
And I should see "The grade provided could not be understood: 50..6"

View file

@ -74,4 +74,3 @@ Feature: Book activity chapter visibility management
And I follow "Next"
And I should see "Fourth chapter" in the ".book_content" "css_element"
And I follow "Exit book"

View file

@ -1,5 +1,5 @@
@mod @mod_choice
Feature: Add choice activity
Feature: Editing choice block
In order to customise choice page
As a teacher or admin
I need to add remove block from the choice page

View file

@ -33,4 +33,3 @@ Feature: A teacher can choose whether to allow duplicate entries in a glossary
And I press "Save changes"
Then I should see "This concept already exists. No duplicates allowed in this glossary."
And I press "Cancel"

View file

@ -36,4 +36,3 @@ Feature: In a lesson activity, teacher can import embedded images in questions a
And "//audio[contains(@title, 'Listen to this greeting:')]/source[contains(@src, 'bonjour.mp3')]" "xpath_element" should exist
And "//*[contains(@class, 'answeroption')]//img[contains(@src, 'pluginfile.php')]" "xpath_element" should exist
And "//*[contains(@class, 'answeroption')]//img[contains(@src, 'flag-france.jpg')]" "xpath_element" should exist

View file

@ -1,5 +1,5 @@
@mod @mod_lesson
Feature: Lesson user override
Feature: Lesson group override
In order to grant a student special access to a lesson
As a teacher
I need to create an override for that user.

View file

@ -1,5 +1,5 @@
@mod @mod_lti
Feature: Content-Item support
Feature: Create/edit tool configuration that has Content-Item support
In order to provide external tools that support the Content-Item Message type for teachers and learners
As an admin
I need to be able to configure external tool registrations that support the Content-Item Message type.

View file

@ -1,5 +1,5 @@
@mod @mod_quiz
Feature: Attemp a quiz where some questions require that the previous question has been answered.
Feature: Attempt a quiz
As a student
In order to demonstrate what I know
I need to be able to attempt quizzes

View file

@ -1,5 +1,5 @@
@mod @mod_quiz
Feature: Attemp a quiz where some questions require that the previous question has been answered.
Feature: Attempt a quiz where some questions require that the previous question has been answered.
In order to complete a quiz where questions require previous ones to be complete
As a student
I need later questions to appear once earlier ones have been answered.

View file

@ -1,5 +1,6 @@
@mod @mod_quiz
Feature: In order to create a quiz that awards marks the way I want
Feature: Edit quiz marks with no attempts
In order to create a quiz that awards marks the way I want
As a teacher
I must be able to set the marks I want on the Edit quiz page.

View file

@ -1,5 +1,6 @@
@mod @mod_quiz
Feature: In order to create a quiz that awards marks the way I want
Feature: Edit quiz marks with attempts
In order to create a quiz that awards marks the way I want
As a teacher
I must be able to set the marks I want on the Edit quiz page (even after the quiz has been attempted).

View file

@ -86,5 +86,3 @@ Feature: A teacher can set a wiki to be collaborative or individual
And I set the field "uid" to "Student 2"
And I should see "Individual student2 edition"
And I should not see "Individual teacher1 edition"

View file

@ -58,7 +58,6 @@ Feature: Users can search wikis
And I should see "Collaborative teacher1 page"
And I log out
@javascript
Scenario: Searching individual wiki
Given I log in as "teacher1"

View file

@ -152,4 +152,3 @@ Feature: Workshop submission and assessment
@javascript
Scenario: Add and assess submissions in workshop with javascript enabled

10
npm-shrinkwrap.json generated
View file

@ -915,6 +915,16 @@
}
}
},
"gherkin": {
"version": "4.0.0",
"from": "gherkin@4.0.0",
"resolved": "https://registry.npmjs.org/gherkin/-/gherkin-4.0.0.tgz"
},
"gherkin-lint": {
"version": "1.1.3",
"from": "gherkin-lint@>=1.1.3 <2.0.0",
"resolved": "https://registry.npmjs.org/gherkin-lint/-/gherkin-lint-1.1.3.tgz"
},
"glob": {
"version": "7.0.5",
"from": "https://registry.npmjs.org/glob/-/glob-7.0.5.tgz",

View file

@ -5,6 +5,7 @@
"devDependencies": {
"async": "1.5.2",
"eslint": "3.7.1",
"gherkin-lint": "1.1.3",
"grunt": "1.0.1",
"grunt-contrib-less": "1.3.0",
"grunt-contrib-uglify": "1.0.1",

View file

@ -47,4 +47,3 @@ Feature: A teacher can duplicate questions in the question bank
And I press "Cancel"
Then I should see "Test question to be copied"
And the field "Select a category" matches value "Test questions (1)"

View file

@ -1,7 +1,7 @@
@qtype @qtype_ddmarker @_switch_window
Feature: Preview a drag-drop onto image question
Feature: Preview a drag-drop marker question
As a teacher
In order to check my drag-drop onto image questions will work for students
In order to check my drag-drop marker questions will work for students
I need to preview them
Background:

View file

@ -24,7 +24,6 @@ Feature: Preview a Short answer question
And I follow "Course 1"
And I navigate to "Question bank" node in "Course administration"
@javascript @_switch_window
Scenario: Preview a Short answer question with correct answer
When I click on "Preview" "link" in the "shortanswer-001" "table_row"

View file

@ -76,4 +76,3 @@ Feature: In a report, admin can see loglive data
And I wait "8" seconds
And I should see "Test name2"
And I log out