moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-28473 fix $instanceids troubles in blocks upgrade

Browse source 
Credit goes to Mateusz Wójcik.
This commit is contained in:
Petr Skoda 2011-08-05 22:08:58 +02:00
parent 3fdc622697
commit 79cfcd3f7d
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/db/upgrade.php
View file

@ -2121,7 +2121,7 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL");
$instanceids[] = $blockinstance->id; $instanceids[] = $blockinstance->id;
// If we have more than 1000 block instances now remove all block positions // If we have more than 1000 block instances now remove all block positions
// and empty the array // and empty the array
if (count($contextids) > 1000) { if (count($instanceids) > 1000) {
$instanceidstring = join(',',$instanceids); $instanceidstring = join(',',$instanceids);
$DB->delete_records_select('block_positions', 'blockinstanceid IN ('.$instanceidstring.')'); $DB->delete_records_select('block_positions', 'blockinstanceid IN ('.$instanceidstring.')');
$instanceids = array(); $instanceids = array();
@ -2131,8 +2131,10 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL");
upgrade_cleanup_unwanted_block_contexts($contextids); upgrade_cleanup_unwanted_block_contexts($contextids);
$instanceidstring = join(',',$instanceids); if ($instanceids) {
$DB->delete_records_select('block_positions', 'blockinstanceid IN ('.$instanceidstring.')'); $instanceidstring = join(',',$instanceids);
$DB->delete_records_select('block_positions', 'blockinstanceid IN ('.$instanceidstring.')');
}
unset($allblockinstances); unset($allblockinstances);
unset($contextids); unset($contextids);