moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-30905 Accessibility: recent activity list is XHTML compliant

Browse source
This commit is contained in:
Frederic Massart 2012-05-23 15:06:17 +08:00
parent 5a5cdaf92e
commit 7eea889b76
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
course/recent.php
View file

@ -221,7 +221,9 @@ if (!empty($activities)) {
echo $OUTPUT->spacer(array('height'=>30, 'br'=>true)); // should be done with CSS instead echo $OUTPUT->spacer(array('height'=>30, 'br'=>true)); // should be done with CSS instead
} }
echo $OUTPUT->box_start(); echo $OUTPUT->box_start();
echo "<h2>$activity->name</h2>"; if (!empty($activity->name)) {
echo html_writer::tag('h2', $activity->name);
}
$inbox = true; $inbox = true;
} else if ($activity->type == 'activity') { } else if ($activity->type == 'activity') {
@ -230,16 +232,17 @@ if (!empty($activities)) {
$cm = $modinfo->cms[$activity->cmid]; $cm = $modinfo->cms[$activity->cmid];
if ($cm->visible) { if ($cm->visible) {
$linkformat = ''; $class = '';
} else { } else {
$linkformat = 'class="dimmed"'; $class = 'dimmed';
} }
$name = format_string($cm->name); $name = format_string($cm->name);
$modfullname = $modnames[$cm->modname]; $modfullname = $modnames[$cm->modname];
$image = "<img src=\"" . $OUTPUT->pix_url('icon', $cm->modname) . "\" class=\"icon\" alt=\"$modfullname\" />"; $image = $OUTPUT->pix_icon('icon', $modfullname, $cm->modname, array('class' => 'icon smallicon'));
echo "<h3>$image $modfullname". $link = html_writer::link(new moodle_url("/mod/$cm->modname/view.php",
" <a href=\"$CFG->wwwroot/mod/$cm->modname/view.php?id=$cm->id\" $linkformat>$name</a></h3>"; array("id" => $cm->id)), $name, array('class' => $class));
echo html_writer::tag('h3', "$image $modfullname $link");
} }
} else { } else {
@ -269,7 +272,7 @@ if (!empty($activities)) {
} else { } else {
echo '<h3><center>' . get_string('norecentactivity') . '</center></h3>'; echo html_writer::tag('h3', get_string('norecentactivity'), array('class' => 'mdl-align'));
} }