moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-27120: Cache DB operations in restore_dbops

Browse source
This commit is contained in:
Tony Levi 2011-04-16 13:33:33 +09:30 • committed by Rajesh Taneja
parent 066af1bbc7
commit 7f98b12f91
1 changed files with 66 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

96
backup/util/dbops/restore_dbops.class.php
View file

@ -28,6 +28,8 @@
* TODO: Finish phpdocs * TODO: Finish phpdocs
*/ */
abstract class restore_dbops { abstract class restore_dbops {
static $BACKUP_IDS_CACHE = array();
static $BACKUP_IDS_EXIST = array();
/** /**
* Return one array containing all the tasks that have been included * Return one array containing all the tasks that have been included
@ -151,6 +153,65 @@ abstract class restore_dbops {
return $problems; return $problems;
} }
protected static function get_backup_ids_cached($restoreid, $itemname, $itemid) {
global $DB;
$key = "$itemid $itemname $restoreid";
if (!isset(self::$BACKUP_IDS_EXIST[$key])) {
return false;
}
if (isset(self::$BACKUP_IDS_CACHE[$key])) {
return self::$BACKUP_IDS_CACHE[$key];
}
$record = array(
'backupid' => $restoreid,
'itemname' => $itemname,
'itemid' => $itemid
);
if (count(self::$BACKUP_IDS_CACHE) > 2048) {
$BACKUP_IDS_CACHE = array();
}
return self::$BACKUP_IDS_CACHE[$key] = $DB->get_record('backup_ids_temp', $record);
}
protected static function set_backup_ids_cached($restoreid, $itemname, $itemid, $extrarecord) {
global $DB;
$key = "$itemid $itemname $restoreid";
if (!isset(self::$BACKUP_IDS_EXIST[$key])) {
$record = array(
'backupid' => $restoreid,
'itemname' => $itemname,
'itemid' => $itemid,
'newitemid' => 0,
'parentitemid' => null,
'info' => null
);
$record = array_merge($record, $extrarecord);
$record['id'] = $DB->insert_record_raw('backup_ids_temp', $record);
self::$BACKUP_IDS_EXIST[$key] = $record['id'];
if (count(self::$BACKUP_IDS_CACHE) < 2048) {
// cache new records if we haven't got many yet
self::$BACKUP_IDS_CACHE[$key] = (object) $record;
}
} else {
if (!empty($extrarecord)) {
$extrarecord['id'] = self::$BACKUP_IDS_EXIST[$key];
$DB->update_record('backup_ids_temp', $extrarecord);
if (isset(self::$BACKUP_IDS_CACHE[$key])) {
$record = array_merge((array)self::$BACKUP_IDS_CACHE[$key], $extrarecord);
self::$BACKUP_IDS_CACHE[$key] = (object) $record;
}
}
}
}
/** /**
* Given one role, as loaded from XML, perform the best possible matching against the assignable * Given one role, as loaded from XML, perform the best possible matching against the assignable
* roles, using different fallback alternatives (shortname, archetype, editingteacher => teacher, defaultcourseroleid) * roles, using different fallback alternatives (shortname, archetype, editingteacher => teacher, defaultcourseroleid)
@ -1219,16 +1280,7 @@ abstract class restore_dbops {
$DB->insert_record('backup_files_temp', $filerec); $DB->insert_record('backup_files_temp', $filerec);
} }
public static function set_backup_ids_record($restoreid, $itemname, $itemid, $newitemid = 0, $parentitemid = null, $info = null) { public static function set_backup_ids_record($restoreid, $itemname, $itemid, $newitemid = 0, $parentitemid = null, $info = null) {
global $DB;
// Build the basic (mandatory) record info
$record = array(
'backupid' => $restoreid,
'itemname' => $itemname,
'itemid' => $itemid
);
// Build conditionally the extra record info // Build conditionally the extra record info
$extrarecord = array(); $extrarecord = array();
if ($newitemid != 0) { if ($newitemid != 0) {
@ -1241,34 +1293,16 @@ abstract class restore_dbops {
$extrarecord['info'] = base64_encode(serialize($info)); $extrarecord['info'] = base64_encode(serialize($info));
} }
// TODO: Analyze if some static (and limited) cache by the 3 params could save us a bunch of get_record() calls self::set_backup_ids_cached($restoreid, $itemname, $itemid, $extrarecord);
// Note: Sure it will! And also will improve getter
if (!$dbrec = $DB->get_record('backup_ids_temp', $record)) { // Need to insert the complete record
$DB->insert_record('backup_ids_temp', array_merge($record, $extrarecord));
} else { // Need to update the extra record info if there is something to
if (!empty($extrarecord)) {
$extrarecord['id'] = $dbrec->id;
$DB->update_record('backup_ids_temp', $extrarecord);
}
}
} }
public static function get_backup_ids_record($restoreid, $itemname, $itemid) { public static function get_backup_ids_record($restoreid, $itemname, $itemid) {
global $DB; $dbrec = self::get_backup_ids_cached($restoreid, $itemname, $itemid);
// Build the basic (mandatory) record info to look for if ($dbrec && isset($dbrec->info) && is_string($dbrec->info)) {
$record = array(
'backupid' => $restoreid,
'itemname' => $itemname,
'itemid' => $itemid
);
// TODO: Analyze if some static (and limited) cache by the 3 params could save us a bunch of get_record() calls
if ($dbrec = $DB->get_record('backup_ids_temp', $record)) {
if ($dbrec->info != null) {
$dbrec->info = unserialize(base64_decode($dbrec->info)); $dbrec->info = unserialize(base64_decode($dbrec->info));
} }
}
return $dbrec; return $dbrec;
} }