MDL-71036 phpunit: Mock->setMethods() silently deprecated

The current ->setMethods() has been silently (won't emit any
warning) in PHPUnit 9. And will stop working (current plans)
in PHPUnit 10.

Basically the now deprecated method has been split into:

- onlyMethods(): To point to existing methods in the mocked artifact.
- addMethods(): To point to non existing (yet) methods in the mocked
  artifact.

In practice that means that all our current setMethods() calls can be
converted to onlyMethods() (existing) and done. The addMethods() is
mostly useful on development phases, not final testing.

Finally note that <null> isn't accepted anymore as parameter to
double all the methods. Instead empty array [] must be used.

Link: https://github.com/sebastianbergmann/phpunit/issues/3770

privacy/tests/manager_test.php

@@ -57,7 +57,7 @@ class privacy_manager_testcase extends advanced_testcase {
      */
     protected function get_mock_manager_with_core_components($componentnames) {
         $mock = $this->getMockBuilder(\core_privacy\manager::class)
-            ->setMethods(['get_component_list'])
+            ->onlyMethods(['get_component_list'])
             ->getMock();
         $mock->expects($this->any())
             ->method('get_component_list')
@@ -336,7 +336,7 @@ class privacy_manager_testcase extends advanced_testcase {
         $mockman = $this->get_mock_manager_with_core_components(['mod_component_broken', 'mod_component_a']);
 
         $observer = $this->getMockBuilder(\core_privacy\manager_observer::class)
-            ->setMethods(['handle_component_failure'])
+            ->onlyMethods(['handle_component_failure'])
             ->getMock();
         $mockman->set_observer($observer);
 
@@ -374,7 +374,7 @@ class privacy_manager_testcase extends advanced_testcase {
         $contextid = $context->id;
 
         $observer = $this->getMockBuilder(\core_privacy\manager_observer::class)
-            ->setMethods(['handle_component_failure'])
+            ->onlyMethods(['handle_component_failure'])
             ->getMock();
         $mockman->set_observer($observer);
 
@@ -409,7 +409,7 @@ class privacy_manager_testcase extends advanced_testcase {
         $contextid = $context->id;
 
         $observer = $this->getMockBuilder(\core_privacy\manager_observer::class)
-            ->setMethods(['handle_component_failure'])
+            ->onlyMethods(['handle_component_failure'])
             ->getMock();
         $mockman->set_observer($observer);
 
@@ -443,7 +443,7 @@ class privacy_manager_testcase extends advanced_testcase {
         $context = \context_system::instance();
 
         $observer = $this->getMockBuilder(\core_privacy\manager_observer::class)
-            ->setMethods(['handle_component_failure'])
+            ->onlyMethods(['handle_component_failure'])
             ->getMock();
         $mockman->set_observer($observer);
 
@@ -473,7 +473,7 @@ class privacy_manager_testcase extends advanced_testcase {
         $context = \context_system::instance();
 
         $observer = $this->getMockBuilder(\core_privacy\manager_observer::class)
-            ->setMethods(['handle_component_failure'])
+            ->onlyMethods(['handle_component_failure'])
             ->getMock();
         $mockman->set_observer($observer);
 

privacy/tests/sitepolicy_test.php

@@ -234,7 +234,7 @@ class sitepolicy_test extends advanced_testcase {
         require_once($CFG->dirroot.'/privacy/tests/fixtures/mock_sitepolicy_handler.php');
 
         $mock = $this->getMockBuilder(\core_privacy\local\sitepolicy\manager::class)
-            ->setMethods(['get_all_handlers'])
+            ->onlyMethods(['get_all_handlers'])
             ->getMock();
         $mock->expects($this->any())
             ->method('get_all_handlers')

privacy/tests/tests_content_writer_test.php

@@ -523,7 +523,7 @@ class tests_content_writer_test extends advanced_testcase {
         $contenthash = file_storage::hash_from_string($filecontent);
 
         $file = $this->getMockBuilder(stored_file::class)
-            ->setMethods(null)
+            ->onlyMethods([])
             ->setConstructorArgs([
                 get_file_storage(),
                 (object) [