moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-71036 phpunit: Mock->setMethods() silently deprecated

Browse source 
The current ->setMethods() has been silently (won't emit any
warning) in PHPUnit 9. And will stop working (current plans)
in PHPUnit 10.

Basically the now deprecated method has been split into:

- onlyMethods(): To point to existing methods in the mocked artifact.
- addMethods(): To point to non existing (yet) methods in the mocked
  artifact.

In practice that means that all our current setMethods() calls can be
converted to onlyMethods() (existing) and done. The addMethods() is
mostly useful on development phases, not final testing.

Finally note that <null> isn't accepted anymore as parameter to
double all the methods. Instead empty array [] must be used.

Link: https://github.com/sebastianbergmann/phpunit/issues/3770
This commit is contained in:
Eloy Lafuente (stronk7) 2021-03-11 19:31:28 +01:00
parent 8a14a7bd22
commit 81407f18ec
42 changed files with 181 additions and 181 deletions
Download patch file Download diff file Expand all files Collapse all files

28
repository/dropbox/tests/api_test.php
View file

@ -83,7 +83,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_has_additional_results($result, $expected) {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(null)
->onlyMethods([])
->getMock();
$this->assertEquals($expected, $mock->has_additional_results($result));
@ -159,7 +159,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_check_and_handle_api_errors($info, $data, $exception, $exceptionmessage) {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(null)
->onlyMethods([])
->getMock();
$mock->info = $info;
@ -254,7 +254,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_supports_thumbnail($entry, $expected) {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(null)
->onlyMethods([])
->getMock();
$this->assertEquals($expected, $mock->supports_thumbnail($entry));
@ -266,7 +266,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_logout_revocation() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(['fetch_dropbox_data'])
->onlyMethods(['fetch_dropbox_data'])
->getMock();
$mock->expects($this->once())
@ -282,7 +282,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_logout_revocation_catch_auth_exception() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(['fetch_dropbox_data'])
->onlyMethods(['fetch_dropbox_data'])
->getMock();
$mock->expects($this->once())
@ -298,7 +298,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_logout_revocation_does_not_catch_other_exceptions() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods(['fetch_dropbox_data'])
->onlyMethods(['fetch_dropbox_data'])
->getMock();
$mock->expects($this->once())
@ -315,7 +315,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_fetch_dropbox_data_endpoint() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'request',
'get_api_endpoint',
'get_content_endpoint',
@ -350,7 +350,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_fetch_dropbox_data_postfields_null() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'request',
])
->getMock();
@ -377,7 +377,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_fetch_dropbox_data_postfields_data() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'request',
])
->getMock();
@ -405,7 +405,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_fetch_dropbox_data_recurse_on_additional_records() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'request',
'get_api_endpoint',
])
@ -456,7 +456,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_fetch_dropbox_content() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'request',
'setHeader',
'get_content_endpoint',
@ -514,7 +514,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_get_file_share_info_existing() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'fetch_dropbox_data',
'normalize_file_share_info',
])
@ -547,7 +547,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_get_file_share_info_new() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'fetch_dropbox_data',
'normalize_file_share_info',
])
@ -588,7 +588,7 @@ class repository_dropbox_api_testcase extends advanced_testcase {
public function test_get_file_share_info_new_failure() {
$mock = $this->getMockBuilder(\repository_dropbox\dropbox::class)
->disableOriginalConstructor()
->setMethods([
->onlyMethods([
'fetch_dropbox_data',
'normalize_file_share_info',
])