moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 17:06:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-51514 gradebook: Optimize set_usedinaggregation query for MySQL

Browse source
This commit is contained in:
Sam Chaffee 2015-10-02 11:28:15 -06:00
parent 35d3e8b00b
commit 84ab39cf77
1 changed files with 21 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

29
lib/grade/grade_category.php
View file

@ -793,15 +793,28 @@ class grade_category extends grade_object {
// Reset aggregation to unknown and 0 for all grade items for this user and category. // Reset aggregation to unknown and 0 for all grade items for this user and category.
$params = array('categoryid' => $this->id, 'userid' => $userid); $params = array('categoryid' => $this->id, 'userid' => $userid);
$itemssql = "SELECT id
FROM {grade_items}
WHERE categoryid = :categoryid";
$sql = "UPDATE {grade_grades} switch ($DB->get_dbfamily()) {
SET aggregationstatus = 'unknown', case 'mysql':
aggregationweight = 0 // Optimize the query for MySQL by using a join rather than a sub-query.
WHERE userid = :userid $sql = "UPDATE {grade_grades} g
AND itemid IN ($itemssql)"; JOIN {grade_items} gi ON (g.itemid = gi.id)
SET g.aggregationstatus = 'unknown',
g.aggregationweight = 0
WHERE g.userid = :userid
AND gi.categoryid = :categoryid";
break;
default:
$itemssql = "SELECT id
FROM {grade_items}
WHERE categoryid = :categoryid";
$sql = "UPDATE {grade_grades}
SET aggregationstatus = 'unknown',
aggregationweight = 0
WHERE userid = :userid
AND itemid IN ($itemssql)";
}
$DB->execute($sql, $params); $DB->execute($sql, $params);