moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-61535 report_security: SQL Perf improvement

Browse source
This commit is contained in:
Olivier Piton 2018-12-13 12:02:23 +08:00 • committed by Andrew Nicols
parent 44890bd738
commit 85e81896fc
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
report/security/locallib.php
View file

@ -466,7 +466,7 @@ function report_security_check_riskxss($detailed=false) {
$params = array('capallow'=>CAP_ALLOW); $params = array('capallow'=>CAP_ALLOW);
$sqlfrom = "FROM (SELECT rcx.* $sqlfrom = "FROM (SELECT DISTINCT rcx.contextid, rcx.roleid
FROM {role_capabilities} rcx FROM {role_capabilities} rcx
JOIN {capabilities} cap ON (cap.name = rcx.capability AND ".$DB->sql_bitand('cap.riskbitmask', RISK_XSS)." <> 0) JOIN {capabilities} cap ON (cap.name = rcx.capability AND ".$DB->sql_bitand('cap.riskbitmask', RISK_XSS)." <> 0)
WHERE rcx.permission = :capallow) rc, WHERE rcx.permission = :capallow) rc,
@ -755,7 +755,7 @@ function report_security_check_riskbackup($detailed=false) {
$params = array('capability'=>'moodle/backup:userinfo', 'permission'=>CAP_ALLOW, 'context1'=>CONTEXT_COURSE, 'context2'=>CONTEXT_COURSE); $params = array('capability'=>'moodle/backup:userinfo', 'permission'=>CAP_ALLOW, 'context1'=>CONTEXT_COURSE, 'context2'=>CONTEXT_COURSE);
$sqluserinfo = " $sqluserinfo = "
FROM (SELECT rcx.* FROM (SELECT DISTINCT rcx.contextid, rcx.roleid
FROM {role_capabilities} rcx FROM {role_capabilities} rcx
WHERE rcx.permission = :permission AND rcx.capability = :capability) rc, WHERE rcx.permission = :permission AND rcx.capability = :capability) rc,
{context} c, {context} c,