moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-09 19:06:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-70285 completion upgrade: fix performance of the MDL-69687 code

Browse source
This commit is contained in:
Tim Hunt 2020-11-23 20:45:46 +00:00
parent 87bcff8c6e
commit 86669b0564
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/db/upgrade.php
View file

@ -2592,11 +2592,12 @@ function xmldb_main_upgrade($oldversion) {
if ($oldversion < 2020061502.09) { if ($oldversion < 2020061502.09) {
// Delete orphaned course_modules_completion rows; these were not deleted properly // Delete orphaned course_modules_completion rows; these were not deleted properly
// by remove_course_contents function. // by remove_course_contents function.
$DB->delete_records_subquery('course_modules_completion', 'id', 'id', $DB->delete_records_select('course_modules_completion', "
"SELECT cmc.id NOT EXISTS (
FROM {course_modules_completion} cmc SELECT 1
LEFT JOIN {course_modules} cm ON cm.id = cmc.coursemoduleid FROM {course_modules} cm
WHERE cm.id IS NULL"); WHERE cm.id = {course_modules_completion}.coursemoduleid
)");
upgrade_main_savepoint(true, 2020061502.09); upgrade_main_savepoint(true, 2020061502.09);
} }