moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-76895 core_courseformat: add detailed bulk selection checks

Browse source 
To prevent future regressions some extra checks has been added to the
bulk_select feature file. The new checks validate the activities and
sections bulk selectors are really selected, not only the total count.
This commit is contained in:
Ferran Recio 2023-03-30 12:13:03 +02:00
parent 0436605df5
commit 879dc5f308
1 changed files with 72 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

72
course/format/tests/behat/bulk_select.feature
View file

@ -52,9 +52,17 @@ Feature: Bulk activity and section selection.
And I click on "Select activity Activity sample 1" "checkbox" And I click on "Select activity Activity sample 1" "checkbox"
And I click on "Select activity Activity sample 2" "checkbox" And I click on "Select activity Activity sample 2" "checkbox"
And I should see "2 selected" in the "sticky-footer" "region" And I should see "2 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value "1"
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
When I click on "Close bulk edit" "button" in the "sticky-footer" "region" When I click on "Close bulk edit" "button" in the "sticky-footer" "region"
And I click on "Bulk edit" "button" And I click on "Bulk edit" "button"
Then I should see "0 selected" in the "sticky-footer" "region" Then I should see "0 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value ""
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
Scenario: Select all is disabled until an activity is selected Scenario: Select all is disabled until an activity is selected
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
@ -74,17 +82,33 @@ Feature: Bulk activity and section selection.
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I click on "Select activity Activity sample 1" "checkbox" And I click on "Select activity Activity sample 1" "checkbox"
And I should see "1 selected" in the "sticky-footer" "region" And I should see "1 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
And the "Select all" "checkbox" should be enabled And the "Select all" "checkbox" should be enabled
When I click on "Select all" "checkbox" in the "sticky-footer" "region" When I click on "Select all" "checkbox" in the "sticky-footer" "region"
Then I should see "4 selected" in the "sticky-footer" "region" Then I should see "4 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value "1"
And the field "Activity sample 3" matches value "1"
And the field "Activity sample 4" matches value "1"
Scenario: Select all when a section is selected will select all sections Scenario: Select all when a section is selected will select all sections
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I click on "Select topic Topic 1" "checkbox" And I click on "Select topic Topic 1" "checkbox"
And I should see "1 selected" in the "sticky-footer" "region" And I should see "1 selected" in the "sticky-footer" "region"
And the field "Select topic Topic 1" matches value "1"
And the field "Select topic Topic 2" matches value ""
And the field "Select topic Topic 3" matches value ""
And the field "Select topic Topic 4" matches value ""
And the "Select all" "checkbox" should be enabled And the "Select all" "checkbox" should be enabled
When I click on "Select all" "checkbox" in the "sticky-footer" "region" When I click on "Select all" "checkbox" in the "sticky-footer" "region"
Then I should see "4 selected" in the "sticky-footer" "region" Then I should see "4 selected" in the "sticky-footer" "region"
And the field "Select topic Topic 1" matches value "1"
And the field "Select topic Topic 2" matches value "1"
And the field "Select topic Topic 3" matches value "1"
And the field "Select topic Topic 4" matches value "1"
Scenario: Click on a select all with all sections selected unselects all sections Scenario: Click on a select all with all sections selected unselects all sections
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
@ -97,6 +121,10 @@ Feature: Bulk activity and section selection.
When I click on "Select all" "checkbox" in the "sticky-footer" "region" When I click on "Select all" "checkbox" in the "sticky-footer" "region"
Then I should see "0 selected" in the "sticky-footer" "region" Then I should see "0 selected" in the "sticky-footer" "region"
And the focused element is "Select topic Topic 1" "checkbox" And the focused element is "Select topic Topic 1" "checkbox"
And the field "Select topic Topic 1" matches value ""
And the field "Select topic Topic 2" matches value ""
And the field "Select topic Topic 3" matches value ""
And the field "Select topic Topic 4" matches value ""
Scenario: Click on a select all with all activity selected unselects all activities Scenario: Click on a select all with all activity selected unselects all activities
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
@ -109,38 +137,82 @@ Feature: Bulk activity and section selection.
When I click on "Select all" "checkbox" in the "sticky-footer" "region" When I click on "Select all" "checkbox" in the "sticky-footer" "region"
Then I should see "0 selected" in the "sticky-footer" "region" Then I should see "0 selected" in the "sticky-footer" "region"
And the focused element is "Select topic Topic 1" "checkbox" And the focused element is "Select topic Topic 1" "checkbox"
And the field "Activity sample 1" matches value ""
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
Scenario: Click an activity name in bulk mode select and unselects the activity Scenario: Click an activity name in bulk mode select and unselects the activity
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I should see "0 selected" in the "sticky-footer" "region" And I should see "0 selected" in the "sticky-footer" "region"
When I click on "Activity sample 1" "link" in the "Topic 1" "section" When I click on "Activity sample 1" "link" in the "Topic 1" "section"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
And I click on "Activity sample 2" "link" in the "Topic 1" "section" And I click on "Activity sample 2" "link" in the "Topic 1" "section"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value "1"
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
And I should see "2 selected" in the "sticky-footer" "region" And I should see "2 selected" in the "sticky-footer" "region"
Then I click on "Activity sample 1" "link" in the "Topic 1" "section" Then I click on "Activity sample 1" "link" in the "Topic 1" "section"
And I should see "1 selected" in the "sticky-footer" "region" And I should see "1 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value ""
And the field "Activity sample 2" matches value "1"
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
Scenario: Select a range of activities using shift Scenario: Select a range of activities using shift
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I should see "0 selected" in the "sticky-footer" "region" And I should see "0 selected" in the "sticky-footer" "region"
When I click on "Activity sample 1" "link" in the "Topic 1" "section" When I click on "Activity sample 1" "link" in the "Topic 1" "section"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value ""
And the field "Activity sample 4" matches value ""
And I shift click on "Activity sample 3" "link" in the "Topic 2" "section" And I shift click on "Activity sample 3" "link" in the "Topic 2" "section"
Then I should see "3 selected" in the "sticky-footer" "region" Then I should see "3 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value "1"
And the field "Activity sample 2" matches value "1"
And the field "Activity sample 3" matches value "1"
And the field "Activity sample 4" matches value ""
Scenario: Select all activities in a section using alt Scenario: Select all activities in a section using alt
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I should see "0 selected" in the "sticky-footer" "region" And I should see "0 selected" in the "sticky-footer" "region"
When I alt click on "Activity sample 3" "link" in the "Topic 2" "section" When I alt click on "Activity sample 3" "link" in the "Topic 2" "section"
Then I should see "2 selected" in the "sticky-footer" "region" Then I should see "2 selected" in the "sticky-footer" "region"
And the field "Activity sample 1" matches value ""
And the field "Activity sample 2" matches value ""
And the field "Activity sample 3" matches value "1"
And the field "Activity sample 4" matches value "1"
Scenario: Select a range of sections using shift Scenario: Select a range of sections using shift
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I should see "0 selected" in the "sticky-footer" "region" And I should see "0 selected" in the "sticky-footer" "region"
When I click on "Select topic Topic 1" "checkbox" When I click on "Select topic Topic 1" "checkbox"
And the field "Select topic Topic 1" matches value "1"
And the field "Select topic Topic 2" matches value ""
And the field "Select topic Topic 3" matches value ""
And the field "Select topic Topic 4" matches value ""
And I shift click on "Select topic Topic 3" "checkbox" in the "page" "region" And I shift click on "Select topic Topic 3" "checkbox" in the "page" "region"
Then I should see "3 selected" in the "sticky-footer" "region" Then I should see "3 selected" in the "sticky-footer" "region"
And the field "Select topic Topic 1" matches value "1"
And the field "Select topic Topic 2" matches value "1"
And the field "Select topic Topic 3" matches value "1"
And the field "Select topic Topic 4" matches value ""
Scenario: Select all section with alt click Scenario: Select all section with alt click
Given I click on "Bulk edit" "button" Given I click on "Bulk edit" "button"
And I should see "0 selected" in the "sticky-footer" "region" And I should see "0 selected" in the "sticky-footer" "region"
And the field "Select topic Topic 1" matches value ""
And the field "Select topic Topic 2" matches value ""
And the field "Select topic Topic 3" matches value ""
And the field "Select topic Topic 4" matches value ""
When I alt click on "Select topic Topic 3" "checkbox" in the "page" "region" When I alt click on "Select topic Topic 3" "checkbox" in the "page" "region"
And I should see "4 selected" in the "sticky-footer" "region" And I should see "4 selected" in the "sticky-footer" "region"
And the field "Select topic Topic 1" matches value "1"
And the field "Select topic Topic 2" matches value "1"
And the field "Select topic Topic 3" matches value "1"
And the field "Select topic Topic 4" matches value "1"