moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 09:26:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-29080 grade: simplified bug fix to prevent users without the required capabilities from being able to export hidden grade items

Browse source
This commit is contained in:
Andrew Davis 2012-02-08 13:45:43 +07:00
parent baa5cd8240
commit 8887fd9a77
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
grade/export/grade_export_form.php
View file

@ -115,7 +115,14 @@ class grade_export_form extends moodleform {
if ($grade_items = $gseq->items) { if ($grade_items = $gseq->items) {
$needs_multiselect = false; $needs_multiselect = false;
$canviewhidden = has_capability('moodle/grade:viewhidden', get_context_instance(CONTEXT_COURSE, $COURSE->id));
foreach ($grade_items as $grade_item) { foreach ($grade_items as $grade_item) {
// Is the grade_item hidden? If so, can the user see hidden grade_items?
if ($grade_item->is_hidden() && !$canviewhidden) {
continue;
}
if (!empty($features['idnumberrequired']) and empty($grade_item->idnumber)) { if (!empty($features['idnumberrequired']) and empty($grade_item->idnumber)) {
$mform->addElement('advcheckbox', 'itemids['.$grade_item->id.']', $grade_item->get_name(), get_string('noidnumber', 'grades')); $mform->addElement('advcheckbox', 'itemids['.$grade_item->id.']', $grade_item->get_name(), get_string('noidnumber', 'grades'));
$mform->hardFreeze('itemids['.$grade_item->id.']'); $mform->hardFreeze('itemids['.$grade_item->id.']');
@ -124,7 +131,7 @@ class grade_export_form extends moodleform {
$mform->setDefault('itemids['.$grade_item->id.']', 1); $mform->setDefault('itemids['.$grade_item->id.']', 1);
$needs_multiselect = true; $needs_multiselect = true;
} }
} }
if ($needs_multiselect) { if ($needs_multiselect) {
$this->add_checkbox_controller(1, null, null, 1); // 1st argument is group name, 2nd is link text, 3rd is attributes and 4th is original value $this->add_checkbox_controller(1, null, null, 1); // 1st argument is group name, 2nd is link text, 3rd is attributes and 4th is original value