MDL-49740 Lock: Fixed task lock release bugs

admin/tool/task/cli/schedule_task.php

@@ -109,7 +109,7 @@ if ($execute = $options['execute']) {
 
     $predbqueries = $DB->perf_get_queries();
     $pretime = microtime(true);
-    try {
+
     mtrace("Scheduled task: " . $task->get_name());
     // NOTE: it would be tricky to move this code to \core\task\manager class,
     //       because we want to do detailed error reporting.
@@ -119,15 +119,19 @@ if ($execute = $options['execute']) {
         exit(129);
     }
     if (!$lock = $cronlockfactory->get_lock('\\' . get_class($task), 10)) {
+        $cronlock->release();
         mtrace('Cannot obtain task lock');
         exit(130);
     }
+
     $task->set_lock($lock);
     if (!$task->is_blocking()) {
         $cronlock->release();
     } else {
         $task->set_cron_lock($cronlock);
     }
+
+    try {
         get_mailer('buffer');
         $task->execute();
         if (isset($predbqueries)) {

lib/classes/lock/db_record_lock_factory.php

@@ -216,7 +216,7 @@ class db_record_lock_factory implements lock_factory {
         // Called from the shutdown handler. Must release all open locks.
         foreach ($this->openlocks as $key => $unused) {
             $lock = new lock($key, $this);
-            $this->release_lock($lock);
+            $lock->release();
         }
     }
 }

lib/classes/lock/postgres_lock_factory.php

@@ -236,7 +236,7 @@ class postgres_lock_factory implements lock_factory {
         // Called from the shutdown handler. Must release all open locks.
         foreach ($this->openlocks as $key => $unused) {
             $lock = new lock($key, $this);
-            $this->release_lock($lock);
+            $lock->release();
         }
     }