moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MSSQL requires to drop defaults before performing

Browse source 
one change of type and, sometimes, a change of length.
This commit is contained in:
stronk7 2007-08-11 00:15:25 +00:00
parent 8e3f40fbbb
commit 89a9688099
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/xmldb/classes/generators/mssql/mssql.class.php
View file

@ -295,6 +295,7 @@ class XMLDBmssql extends XMLDBgenerator {
$olddefault = empty($metac->has_default) ? null : strtok($metac->default_value, ':'); $olddefault = empty($metac->has_default) ? null : strtok($metac->default_value, ':');
$typechanged = true; //By default, assume that the column type has changed $typechanged = true; //By default, assume that the column type has changed
$lengthchanged = true; //By default, assume that the column length has changed
/// Detect if we are changing the type of the column /// Detect if we are changing the type of the column
if (($xmldb_field->getType() == XMLDB_TYPE_INTEGER && substr($oldmetatype, 0, 1) == 'I') || if (($xmldb_field->getType() == XMLDB_TYPE_INTEGER && substr($oldmetatype, 0, 1) == 'I') ||
@ -306,8 +307,14 @@ class XMLDBmssql extends XMLDBgenerator {
$typechanged = false; $typechanged = false;
} }
/// If type has changed drop the default if exists /// Detect if we are changing the length of the column, not always necessary to drop defaults
if ($typechanged) { /// if only the length changes, but it's safe to do it always
if ($xmldb_field->getLength() == $oldlength) {
$lengthchanged = false;
}
/// If type or length have changed drop the default if exists
if ($typechanged || $lengthchanged) {
$results = $this->getDropDefaultSQL($xmldb_table, $xmldb_field); $results = $this->getDropDefaultSQL($xmldb_table, $xmldb_field);
} }
@ -316,7 +323,7 @@ class XMLDBmssql extends XMLDBgenerator {
$results = array_merge($results, parent::getAlterFieldSQL($xmldb_table, $xmldb_field)); // Call parent $results = array_merge($results, parent::getAlterFieldSQL($xmldb_table, $xmldb_field)); // Call parent
/// Finally, process the default clause to add it back if necessary /// Finally, process the default clause to add it back if necessary
if ($typechanged) { if ($typechanged || $lengthchanged) {
$results = array_merge($results, $this->getCreateDefaultSQL($xmldb_table, $xmldb_field)); $results = array_merge($results, $this->getCreateDefaultSQL($xmldb_table, $xmldb_field));
} }