From dc3826eed73a677a53b2f6de6d7e8a8886cf60aa Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Wed, 9 Feb 2011 20:48:21 +0000 Subject: [PATCH] MDL-26338 fix mixed types in quiz reports SQL. This was breaking Oracle --- mod/quiz/report/overview/report.php | 2 +- mod/quiz/report/responses/report.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php index 0ef2a32f7e5..7a9b5e14577 100644 --- a/mod/quiz/report/overview/report.php +++ b/mod/quiz/report/overview/report.php @@ -202,7 +202,7 @@ class quiz_overview_report extends quiz_default_report { if (!$nostudents || ($attemptsmode == QUIZ_REPORT_ATTEMPTS_ALL)) { // Construct the SQL - $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, \'0\')').' AS uniqueid, '; + $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, 0)').' AS uniqueid, '; if ($qmsubselect) { $fields .= "(CASE " . diff --git a/mod/quiz/report/responses/report.php b/mod/quiz/report/responses/report.php index b73ccfd7517..01662ff6a6b 100644 --- a/mod/quiz/report/responses/report.php +++ b/mod/quiz/report/responses/report.php @@ -185,7 +185,7 @@ class quiz_responses_report extends quiz_default_report { $hasfeedback = quiz_has_feedback($quiz); // Construct the SQL - $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, \'0\')').' AS concattedid, '; + $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, 0)').' AS concattedid, '; if ($qmsubselect) { $fields .= "(CASE " .