moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

changed to outer join as user_lastaccess table could contain null

Browse source
This commit is contained in:
toyomoyo 2006-09-13 05:29:26 +00:00
parent 7da0af9feb
commit 8ca1053a45
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
user/index.php
View file

@ -381,13 +381,10 @@ function checkchecked(form) {
$select = 'SELECT u.id, u.username, u.firstname, u.lastname, u.email, u.city, u.country, $select = 'SELECT u.id, u.username, u.firstname, u.lastname, u.email, u.city, u.country,
u.picture, u.lang, u.timezone, u.emailstop, u.maildisplay, ul.timeaccess AS lastaccess '; // s.lastaccess u.picture, u.lang, u.timezone, u.emailstop, u.maildisplay, ul.timeaccess AS lastaccess '; // s.lastaccess
//$select .= $course->enrolperiod?', s.timeend ':''; //$select .= $course->enrolperiod?', s.timeend ':'';
$from = "FROM {$CFG->prefix}user u, $from = "FROM {$CFG->prefix}user u INNER JOIN
{$CFG->prefix}role_assignments r, {$CFG->prefix}role_assignments r on u.id=r.userid LEFT JOIN
{$CFG->prefix}user_lastaccess ul "; {$CFG->prefix}user_lastaccess ul on u.id=ul.userid ";
$where = "WHERE $where = "WHERE (r.contextid = $context->id OR r.contextid in $listofcontexts)
r.userid = u.id
AND u.id = ul.userid
AND (r.contextid = $context->id OR r.contextid in $listofcontexts)
AND u.deleted = 0 AND u.deleted = 0
AND r.roleid = $roleid AND r.roleid = $roleid
AND ul.courseid = $course->id "; AND ul.courseid = $course->id ";