moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-43200 fix enrol_manual externallib tests

Browse source
This commit is contained in:
Petr Škoda 2014-02-12 16:00:09 +08:00
parent e52bbf07a8
commit 900b1bf7d1
1 changed files with 65 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

84
enrol/manual/tests/externallib_test.php
View file

@ -18,7 +18,7 @@
* Enrol manual external PHPunit tests * Enrol manual external PHPunit tests
* *
* @package enrol_manual * @package enrol_manual
* @category external * @category phpunit
* @copyright 2012 Jerome Mouneyrac * @copyright 2012 Jerome Mouneyrac
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @since Moodle 2.4 * @since Moodle 2.4
@ -31,43 +31,87 @@ global $CFG;
require_once($CFG->dirroot . '/webservice/tests/helpers.php'); require_once($CFG->dirroot . '/webservice/tests/helpers.php');
require_once($CFG->dirroot . '/enrol/manual/externallib.php'); require_once($CFG->dirroot . '/enrol/manual/externallib.php');
class enrol_manual_external_testcase extends externallib_advanced_testcase { class enrol_manual_externallib_testcase extends externallib_advanced_testcase {
/** /**
* Test get_enrolled_users * Test get_enrolled_users
*/ */
public function test_enrol_users() { public function test_enrol_users() {
global $USER, $CFG; global $DB;
$this->resetAfterTest(true); $this->resetAfterTest(true);
$course = self::getDataGenerator()->create_course(); $user = self::getDataGenerator()->create_user();
$this->setUser($user);
$course1 = self::getDataGenerator()->create_course();
$course2 = self::getDataGenerator()->create_course();
$user1 = self::getDataGenerator()->create_user(); $user1 = self::getDataGenerator()->create_user();
$user2 = self::getDataGenerator()->create_user(); $user2 = self::getDataGenerator()->create_user();
// Set the required capabilities by the external function. $context1 = context_course::instance($course1->id);
$context = context_course::instance($course->id); $context2 = context_course::instance($course2->id);
$roleid = $this->assignUserCapability('enrol/manual:enrol', $context->id); $instance1 = $DB->get_record('enrol', array('courseid' => $course1->id, 'enrol' => 'manual'), '*', MUST_EXIST);
$this->assignUserCapability('moodle/course:view', $context->id, $roleid); $instance2 = $DB->get_record('enrol', array('courseid' => $course2->id, 'enrol' => 'manual'), '*', MUST_EXIST);
// Add manager role to $USER. // Set the required capabilities by the external function.
// So $USER is allowed to assign 'manager', 'editingteacher', 'teacher' and 'student'. $roleid = $this->assignUserCapability('enrol/manual:enrol', $context1->id);
role_assign(1, $USER->id, context_system::instance()->id); $this->assignUserCapability('moodle/course:view', $context1->id, $roleid);
$this->assignUserCapability('moodle/role:assign', $context1->id, $roleid);
$this->assignUserCapability('enrol/manual:enrol', $context2->id, $roleid);
$this->assignUserCapability('moodle/course:view', $context2->id, $roleid);
$this->assignUserCapability('moodle/role:assign', $context2->id, $roleid);
allow_assign($roleid, 3);
// Call the external function. // Call the external function.
enrol_manual_external::enrol_users(array( enrol_manual_external::enrol_users(array(
array('roleid' => 3, 'userid' => $user1->id, 'courseid' => $course->id), array('roleid' => 3, 'userid' => $user1->id, 'courseid' => $course1->id),
array('roleid' => 3, 'userid' => $user2->id, 'courseid' => $course->id) array('roleid' => 3, 'userid' => $user2->id, 'courseid' => $course1->id),
)); ));
// Check we retrieve the good total number of enrolled users. $this->assertEquals(2, $DB->count_records('user_enrolments', array('enrolid' => $instance1->id)));
require_once($CFG->dirroot . '/enrol/externallib.php'); $this->assertEquals(0, $DB->count_records('user_enrolments', array('enrolid' => $instance2->id)));
$enrolledusers = core_enrol_external::get_enrolled_users($course->id); $this->assertTrue(is_enrolled($context1, $user1));
$this->assertEquals(2, count($enrolledusers)); $this->assertTrue(is_enrolled($context1, $user2));
// Call without required capability. // Call without required capability.
$this->unassignUserCapability('enrol/manual:enrol', $context->id, $roleid); $DB->delete_records('user_enrolments');
$this->setExpectedException('moodle_exception'); $this->unassignUserCapability('enrol/manual:enrol', $context1->id, $roleid);
$categories = enrol_manual_external::enrol_users($course->id); try {
enrol_manual_external::enrol_users(array(
array('roleid' => 3, 'userid' => $user1->id, 'courseid' => $course1->id),
));
$this->fail('Exception expected if not having capability to enrol');
} catch (moodle_exception $e) {
$this->assertInstanceOf('required_capability_exception', $e);
$this->assertSame('nopermissions', $e->errorcode);
}
$this->assignUserCapability('enrol/manual:enrol', $context1->id, $roleid);
$this->assertEquals(0, $DB->count_records('user_enrolments'));
// Call with forbidden role.
try {
enrol_manual_external::enrol_users(array(
array('roleid' => 1, 'userid' => $user1->id, 'courseid' => $course1->id),
));
$this->fail('Exception expected if not allowed to assign role.');
} catch (moodle_exception $e) {
$this->assertSame('wsusercannotassign', $e->errorcode);
}
$this->assertEquals(0, $DB->count_records('user_enrolments'));
// Call for course without manual instance.
$DB->delete_records('user_enrolments');
$DB->delete_records('enrol', array('courseid' => $course2->id));
try {
enrol_manual_external::enrol_users(array(
array('roleid' => 3, 'userid' => $user1->id, 'courseid' => $course1->id),
array('roleid' => 3, 'userid' => $user1->id, 'courseid' => $course2->id),
));
$this->fail('Exception expected if course does not have manual instance');
} catch (moodle_exception $e) {
$this->assertSame('wsnoinstance', $e->errorcode);
}
} }
} }