moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merged get_record caching from MDL-7196 in stable (thanks sam!)

Browse source
This commit is contained in:
moodler 2006-10-26 07:57:07 +00:00
parent 4e86c6d735
commit 92309430b8
1 changed files with 31 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

35
lib/dmllib.php
View file

@ -39,6 +39,7 @@
$empty_rs_cache = array(); // Keeps copies of the recordsets used in one invocation $empty_rs_cache = array(); // Keeps copies of the recordsets used in one invocation
$metadata_cache = array(); // Keeps copies of the MetaColumns() for each table used in one invocations $metadata_cache = array(); // Keeps copies of the MetaColumns() for each table used in one invocations
$record_cache = array(); // Keeps copies of all simple get_record results from one invocation
/// FUNCTIONS FOR DATABASE HANDLING //////////////////////////////// /// FUNCTIONS FOR DATABASE HANDLING ////////////////////////////////
@ -354,6 +355,7 @@ function count_records_sql($sql) {
/// GENERIC FUNCTIONS TO GET, INSERT, OR UPDATE DATA /////////////////////////////////// /// GENERIC FUNCTIONS TO GET, INSERT, OR UPDATE DATA ///////////////////////////////////
/** /**
* Get a single record as an object * Get a single record as an object
* *
@ -368,12 +370,29 @@ function count_records_sql($sql) {
* @return mixed a fieldset object containing the first mathcing record, or false if none found. * @return mixed a fieldset object containing the first mathcing record, or false if none found.
*/ */
function get_record($table, $field1, $value1, $field2='', $value2='', $field3='', $value3='', $fields='*') { function get_record($table, $field1, $value1, $field2='', $value2='', $field3='', $value3='', $fields='*') {
global $CFG; global $CFG, $record_cache;
// Check to see whether this record is eligible for caching (fields=*, only condition is id)
$docache = false;
if ($field1=='id' && !$field2 && !$field3 && $fields=='*') {
$docache = true;
// If it's in the cache, return it
if (!empty($record_cache[$table][$value1])) {
return $record_cache[$table][$value1];
}
}
$select = where_clause($field1, $value1, $field2, $value2, $field3, $value3); $select = where_clause($field1, $value1, $field2, $value2, $field3, $value3);
return get_record_sql('SELECT '.$fields.' FROM '. $CFG->prefix . $table .' '. $select); $record = get_record_sql('SELECT '.$fields.' FROM '. $CFG->prefix . $table .' '. $select);
// If we're caching records, store this one (supposing we got something - we don't cache failures)
if ($record && $docache) {
$record_cache[$table][$value1] = $record;
}
return $record;
} }
/** /**
@ -1022,6 +1041,10 @@ function set_field($table, $newfield, $newvalue, $field1, $value1, $field2='', $
} }
} }
// Clear entire record cache for table (could be improved to check for ID limitation)
global $record_cache;
unset($record_cache[$table]);
/// Arriving here, standard update /// Arriving here, standard update
return $db->Execute('UPDATE '. $CFG->prefix . $table .' SET '. $newfield .' = \''. $newvalue .'\' '. $select); return $db->Execute('UPDATE '. $CFG->prefix . $table .' SET '. $newfield .' = \''. $newvalue .'\' '. $select);
} }
@ -1276,6 +1299,10 @@ function update_record($table, $dataobject) {
return false; return false;
} }
// Remove this record from record cache since it will change
global $record_cache;
unset($record_cache[$table][$dataobject->id]);
/// Temporary hack as part of phasing out all access to obsolete user tables XXX /// Temporary hack as part of phasing out all access to obsolete user tables XXX
if (!empty($CFG->rolesactive)) { if (!empty($CFG->rolesactive)) {
if (in_array($table, array('user_students', 'user_teachers', 'user_coursecreators', 'user_admins'))) { if (in_array($table, array('user_students', 'user_teachers', 'user_coursecreators', 'user_admins'))) {