MDL-20169 fixed coding style, parameter type required

This commit is contained in:
skodak 2009-08-27 19:14:45 +00:00
parent 622365d2e1
commit 92ebcabeb3
16 changed files with 48 additions and 48 deletions

View file

@ -8,10 +8,10 @@
require_once ("backuplib.php");
require_once ("$CFG->libdir/adminlib.php");
$id = optional_param( 'id' ); // course id
$to = optional_param( 'to' ); // id of course to import into afterwards.
$cancel = optional_param( 'cancel' );
$launch = optional_param( 'launch' );
$id = optional_param('id', 0, PARAM_INT); // course id
$to = optional_param('to', 0, PARAM_INT); // id of course to import into afterwards.
$cancel = optional_param('cancel', '', PARAM_RAW);
$launch = optional_param('launch', '', PARAM_ACTION);
$loginurl = get_login_url();

View file

@ -54,23 +54,23 @@
//Check data
//Check module info
$var = "backup_".$modname;
$$var = optional_param( $var,1);
$$var = optional_param( $var,1, PARAM_CLEAN);
//Check include user info
$var = "backup_user_info_".$modname;
$$var = optional_param( $var,1);
$$var = optional_param( $var,1, PARAM_CLEAN);
}
}
//Check other parameters
$backup_metacourse = optional_param('backup_metacourse',1);
$backup_users = optional_param('backup_users',1);
$backup_logs = optional_param('backup_logs',0);
$backup_user_files = optional_param('backup_user_files',1);
$backup_course_files = optional_param('backup_course_files',1);
$backup_site_files = optional_param('backup_site_files',1);
$backup_metacourse = optional_param('backup_metacourse',1, PARAM_BOOL);
$backup_users = optional_param('backup_users',1, PARAM_BOOL);
$backup_logs = optional_param('backup_logs',0, PARAM_BOOL);
$backup_user_files = optional_param('backup_user_files',1, PARAM_BOOL);
$backup_course_files = optional_param('backup_course_files',1, PARAM_BOOL);
$backup_site_files = optional_param('backup_site_files',1, PARAM_BOOL);
$backup_gradebook_history = optional_param('backup_gradebook_history', 0, PARAM_INT);
$backup_messages = optional_param('backup_messages',1);
$backup_blogs = optional_param('backup_blogs',1);
$backup_messages = optional_param('backup_messages',1, PARAM_BOOL);
$backup_blogs = optional_param('backup_blogs',1, PARAM_BOOL);
if ($count == 0) {
notice("No backupable modules are installed!");
@ -175,11 +175,11 @@ function selectItemInCheckboxByName(formId, checkName, checked ) {
foreach ($instances as $instance) {
echo '<tr><td>';
$var = 'backup_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,1);
$$var = optional_param($var,1, PARAM_CLEAN);
print_checkbox($var,$$var,$$var,$instance->name,$instance->name,'this.form.elements[\'backup_'.$modname.'\'].checked=1;');
echo '</td><td align="right">&nbsp;';
$var = 'backup_user_info_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,1);
$$var = optional_param($var,1, PARAM_CLEAN);
if (empty($to)) {
print_checkbox($var,$$var,$$var,get_string('userdata'),'','this.form.elements[\'backup_user_info_'.$modname.'\'].checked=1;');
} else {

View file

@ -2724,11 +2724,11 @@
foreach ($preferences->$varname as $instance) {
$preferences->mods[$modname]->instances[$instance->id]->name = $instance->name;
$var = 'backup_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,0);
$$var = optional_param($var,0, PARAM_CLEAN);
$preferences->$var = $$var;
$preferences->mods[$modname]->instances[$instance->id]->backup = $$var;
$var = 'backup_user_info_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,0);
$$var = optional_param($var,0, PARAM_CLEAN);
$preferences->$var = $$var;
$preferences->mods[$modname]->instances[$instance->id]->userinfo = $$var;
$var = 'backup_'.$modname.'_instances';
@ -2740,13 +2740,13 @@
$preferences->mods[$modname]->name = $modname;
$var = "backup_".$modname;
$$var = optional_param( $var,0);
$$var = optional_param( $var,0, PARAM_CLEAN);
$preferences->$var = $$var;
$preferences->mods[$modname]->backup = $$var;
//Check include user info
$var = "backup_user_info_".$modname;
$$var = optional_param( $var,0);
$$var = optional_param( $var,0, PARAM_CLEAN);
$preferences->$var = $$var;
$preferences->mods[$modname]->userinfo = $$var;

View file

@ -14,12 +14,12 @@
require_once("$CFG->libdir/adminlib.php");
//Optional
$id = optional_param( 'id' );
$file = optional_param( 'file' );
$cancel = optional_param( 'cancel' );
$launch = optional_param( 'launch' );
$to = optional_param( 'to' );
$method = optional_param( 'method' );
$id = optional_param('id', 0, PARAM_INT);
$file = optional_param( 'file', 0, PARAM_PATH);
$cancel = optional_param('cancel', '', PARAM_RAW);
$launch = optional_param( 'launch', '', PARAM_ACTION);
$to = optional_param('to', '', PARAM_INT);
$method = optional_param('method', '', PARAM_ACTION);
$backup_unique_code = optional_param('backup_unique_code',0,PARAM_INT);
//Get and check course

View file

@ -68,9 +68,9 @@
foreach ($allmods as $mod) {
$modname = $mod->name;
$var = "restore_".$modname;
$$var = optional_param( $var,0);
$$var = optional_param( $var,0, PARAM_CLEAN);
$var = "restore_user_info_".$modname;
$$var = optional_param( $var,0);
$$var = optional_param( $var,0, PARAM_CLEAN);
$instances = !empty($info->mods[$mod->name]->instances) ? $info->mods[$mod->name]->instances : NULL;
if ($instances === NULL) {
continue;

View file

@ -370,11 +370,11 @@ function selectItemInCheckboxByName(formId, checkName, checked ) {
foreach ($instances as $instance) {
echo '<tr><td>';
$var = 'restore_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,1);
$$var = optional_param($var,1, PARAM_CLEAN);
print_checkbox($var,$$var,$$var,$instance->name,$instance->name,'this.form.elements[\'restore_'.$modname.'\'].checked=1;');
echo '</td><td align="right">&nbsp;';
$var = 'restore_user_info_'.$modname.'_instance_'.$instance->id;
$$var = optional_param($var,1);
$$var = optional_param($var,1, PARAM_CLEAN);
if (!empty($info->mods[$modname]->instances) && ($info->mods[$modname]->instances[$instance->id]->userinfo == 'true')) {
print_checkbox($var,$$var,$$var,get_string('userdata'),'','this.form.elements[\'restore_user_info_'.$modname.'\'].checked=1;');
} else {