Merge branch 'MDL-81509_final-deprecation-of-task_base-is_blocking-and-set_blocking' of https://github.com/ziegenberg/moodle

This commit is contained in:
Huong Nguyen 2024-11-14 11:07:45 +07:00
commit 94568bc5e0
No known key found for this signature in database
GPG key ID: 40D88AB693A3E72A
2 changed files with 12 additions and 13 deletions

View file

@ -0,0 +1,7 @@
issueNumber: MDL-81509
notes:
core:
- message: >-
Final deprecation of methods task_base::is_blocking and
task_base::set_blocking.
type: removed

View file

@ -116,39 +116,31 @@ abstract class task_base {
} }
/** /**
* Setter for $blocking.
*
* Please note that task blocking is no longer supported.
* If you are using it in older versions of Moodle you are strongly advised to rewrite your code
* as has a detrimental impact upon performance.
*
* @deprecated since Moodle 4.4 See MDL-67667 * @deprecated since Moodle 4.4 See MDL-67667
* @todo Remove in MDL-81509
*/ */
#[\core\attribute\deprecated( #[\core\attribute\deprecated(
replacement: null, replacement: null,
since: '4.4', since: '4.4',
mdl: 'MDL-67667',
reason: 'Blocking tasks are no longer supported', reason: 'Blocking tasks are no longer supported',
final: true,
)] )]
public function set_blocking($blocking) { public function set_blocking() {
\core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]); \core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]);
} }
/** /**
* Getter for $blocking.
*
* @return bool
* @deprecated since Moodle 4.4 See MDL-67667 * @deprecated since Moodle 4.4 See MDL-67667
* @todo Remove in MDL-81509
*/ */
#[\core\attribute\deprecated( #[\core\attribute\deprecated(
replacement: null, replacement: null,
since: '4.4', since: '4.4',
mdl: 'MDL-67667',
reason: 'Blocking tasks are no longer supported', reason: 'Blocking tasks are no longer supported',
final: true,
)] )]
public function is_blocking() { public function is_blocking() {
\core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]); \core\deprecation::emit_deprecation_if_present([$this, __FUNCTION__]);
return false;
} }
/** /**