moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-68312 gradereport_grader: Use caption instead of summary in table

Browse source 
The summary attribute on the table element is obsolete.
This commit is contained in:
Shamim Rezaie 2020-04-03 05:42:59 +11:00
parent 68fd8d8bdf
commit 96896e0dd7
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
grade/report/grader/lib.php
View file

@ -1265,7 +1265,8 @@ class grade_report_grader extends grade_report {
$fulltable = new html_table(); $fulltable = new html_table();
$fulltable->attributes['class'] = 'gradereport-grader-table'; $fulltable->attributes['class'] = 'gradereport-grader-table';
$fulltable->id = 'user-grades'; $fulltable->id = 'user-grades';
$fulltable->summary = get_string('summarygrader', 'gradereport_grader'); $fulltable->caption = get_string('summarygrader', 'gradereport_grader');
$fulltable->captionhide = true;
// Extract rows from each side (left and right) and collate them into one row each // Extract rows from each side (left and right) and collate them into one row each
foreach ($leftrows as $key => $row) { foreach ($leftrows as $key => $row) {

6
lib/outputcomponents.php
View file

@ -2765,6 +2765,12 @@ class html_table {
/** /**
* @var string Description of the contents for screen readers. * @var string Description of the contents for screen readers.
*
* The "summary" attribute on the "table" element is not supported in HTML5.
* Consider describing the structure of the table in a "caption" element or in a "figure" element containing the table;
* or, simplify the structure of the table so that no description is needed.
*
* @deprecated since Moodle 3.9.
*/ */
public $summary; public $summary;