moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-32825 try to improve atomicity of cache file operations in themes and javascript

Browse source
This commit is contained in:
Petr Skoda 2012-05-07 17:35:09 +02:00
parent 4dd63b6d70
commit 979d320722
6 changed files with 105 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

37
lib/jslib.php
View file

@ -154,3 +154,40 @@ EOD;
}
return $js;
}
/**
* Create cache file for JS content
* @param string $file full file path to cache file
* @param string $content JS code
*/
function js_write_cache_file_content($file, $content) {
global $CFG;
clearstatcache();
if (!file_exists(dirname($file))) {
@mkdir(dirname($file), $CFG->directorypermissions, true);
}
// Prevent serving of incomplete file from concurrent request,
// the rename() should be more atomic than fwrite().
ignore_user_abort(true);
if ($fp = fopen($file.'.tmp', 'xb')) {
fwrite($fp, $content);
fclose($fp);
rename($file.'.tmp', $file);
@chmod($file, $CFG->filepermissions);
@unlink($file.'.tmp'); // just in case anything fails
}
ignore_user_abort(false);
if (connection_aborted()) {
die;
}
}
/**
* Sends a 404 message about CSS not being found.
*/
function js_send_css_not_found() {
header('HTTP/1.0 404 not found');
die('JS was not found, sorry.');
}