moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-53452 tool_lp: Rename get_course_settings to get_by_courseid

Browse source 
In the course_competency_settings persistent.
This commit is contained in:
Damyon Wiese 2016-03-29 16:50:21 +08:00 • committed by Frederic Massart
parent 9785dd8174
commit 9919b4af62
4 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
admin/tool/lp/classes/api.php
View file

@ -4212,7 +4212,7 @@ class api {
} }
// Check the course settings to see if we should push to user plans. // Check the course settings to see if we should push to user plans.
$coursesettings = course_competency_settings::get_course_settings($courseid); $coursesettings = course_competency_settings::get_by_courseid($courseid);
$setucgrade = $coursesettings->get_pushratingstouserplans(); $setucgrade = $coursesettings->get_pushratingstouserplans();
if ($setucgrade) { if ($setucgrade) {
@ -4276,7 +4276,7 @@ class api {
// Set proficiency. // Set proficiency.
$usercompetencycourse->set_proficiency($proficiency); $usercompetencycourse->set_proficiency($proficiency);
$coursesettings = course_competency_settings::get_course_settings($courseid); $coursesettings = course_competency_settings::get_by_courseid($courseid);
if (!$coursesettings->get_pushratingstouserplans()) { if (!$coursesettings->get_pushratingstouserplans()) {
$setucgrade = false; $setucgrade = false;
} }
@ -4872,7 +4872,7 @@ class api {
throw new required_capability_exception($context, 'tool/lp:coursecompetencyview', 'nopermissions', ''); throw new required_capability_exception($context, 'tool/lp:coursecompetencyview', 'nopermissions', '');
} }
return course_competency_settings::get_course_settings($courseid); return course_competency_settings::get_by_courseid($courseid);
} }
/** /**

2
admin/tool/lp/classes/course_competency_settings.php
View file

@ -61,7 +61,7 @@ class course_competency_settings extends persistent {
* @param int $courseid The course id * @param int $courseid The course id
* @return course_competency_settings * @return course_competency_settings
*/ */
public static function get_course_settings($courseid) { public static function get_by_courseid($courseid) {
global $DB; global $DB;
$params = array( $params = array(

8
admin/tool/lp/tests/course_competency_settings_test.php
View file

@ -76,21 +76,21 @@ class tool_lp_course_competency_settings_testcase extends advanced_testcase {
set_config('pushcourseratingstouserplans', true, 'tool_lp'); set_config('pushcourseratingstouserplans', true, 'tool_lp');
$coursesettings = course_competency_settings::get_course_settings($c1->id); $coursesettings = course_competency_settings::get_by_courseid($c1->id);
$this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans()); $this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans());
set_config('pushcourseratingstouserplans', false, 'tool_lp'); set_config('pushcourseratingstouserplans', false, 'tool_lp');
$coursesettings = course_competency_settings::get_course_settings($c1->id); $coursesettings = course_competency_settings::get_by_courseid($c1->id);
$this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans()); $this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans());
api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => true)); api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => true));
$coursesettings = course_competency_settings::get_course_settings($c1->id); $coursesettings = course_competency_settings::get_by_courseid($c1->id);
$this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans()); $this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans());
set_config('pushcourseratingstouserplans', true, 'tool_lp'); set_config('pushcourseratingstouserplans', true, 'tool_lp');
api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => false)); api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => false));
$coursesettings = course_competency_settings::get_course_settings($c1->id); $coursesettings = course_competency_settings::get_by_courseid($c1->id);
$this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans()); $this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans());
// Right now the setting is false. // Right now the setting is false.

4
admin/tool/lp/tests/externallib_test.php
View file

@ -3080,13 +3080,13 @@ class tool_lp_external_testcase extends externallib_advanced_testcase {
// Start the test. // Start the test.
$result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => true)); $result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => true));
$settings = course_competency_settings::get_course_settings($course->id); $settings = course_competency_settings::get_by_courseid($course->id);
$this->assertTrue((bool)$settings->get_pushratingstouserplans()); $this->assertTrue((bool)$settings->get_pushratingstouserplans());
$result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => false)); $result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => false));
$settings = course_competency_settings::get_course_settings($course->id); $settings = course_competency_settings::get_by_courseid($course->id);
$this->assertFalse((bool)$settings->get_pushratingstouserplans()); $this->assertFalse((bool)$settings->get_pushratingstouserplans());
$this->setUser($compnoob); $this->setUser($compnoob);