moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-09 19:06:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-43058 reports: updated sql to return fullnames in security check reports.

Browse source
This commit is contained in:
Adrian Greeve 2013-11-27 14:43:33 +08:00
parent ca3b210680
commit 9daaa37aac
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
report/security/locallib.php
View file

@ -508,7 +508,8 @@ function report_security_check_riskxss($detailed=false) {
$result->info = get_string('check_riskxss_warning', 'report_security', $count); $result->info = get_string('check_riskxss_warning', 'report_security', $count);
if ($detailed) { if ($detailed) {
$users = $DB->get_records_sql("SELECT DISTINCT u.id, u.firstname, u.lastname, u.picture, u.imagealt $sqlfrom", $params); $userfields = user_picture::fields('u');
$users = $DB->get_records_sql("SELECT DISTINCT $userfields $sqlfrom", $params);
foreach ($users as $uid=>$user) { foreach ($users as $uid=>$user) {
$users[$uid] = fullname($user); $users[$uid] = fullname($user);
} }
@ -710,7 +711,8 @@ function report_security_check_riskadmin($detailed=false) {
$result->status = null; $result->status = null;
$result->link = null; $result->link = null;
$sql = "SELECT u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.email $userfields = user_picture::fields('u');
$sql = "SELECT $userfields
FROM {user} u FROM {user} u
WHERE u.id IN ($CFG->siteadmins)"; WHERE u.id IN ($CFG->siteadmins)";
@ -834,7 +836,8 @@ function report_security_check_riskbackup($detailed=false) {
$users = array(); $users = array();
list($sort, $sortparams) = users_order_by_sql('u'); list($sort, $sortparams) = users_order_by_sql('u');
$rs = $DB->get_recordset_sql("SELECT DISTINCT u.id, u.firstname, u.lastname, u.picture, u.imagealt, u.email, ra.contextid, ra.roleid $userfields = user_picture::fields('u');
$rs = $DB->get_recordset_sql("SELECT DISTINCT $userfields, ra.contextid, ra.roleid
$sqluserinfo ORDER BY $sort", array_merge($params, $sortparams)); $sqluserinfo ORDER BY $sort", array_merge($params, $sortparams));
foreach ($rs as $user) { foreach ($rs as $user) {