moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-49743 singleview: slightly clarify logic

Browse source 
Make it clearer what the 'unset' behaviour is because previously
we've set the default for 'empty' values twice.
This commit is contained in:
Dan Poltawski 2015-11-25 15:00:49 +00:00
parent 453f69263f
commit a24abd55e0
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
grade/report/singleview/index.php
View file

@ -35,12 +35,12 @@ $userid = optional_param('userid', null, PARAM_INT);
$defaulttype = $userid ? 'user' : 'select'; $defaulttype = $userid ? 'user' : 'select';
$itemid = optional_param('itemid', $userid, PARAM_INT); $itemid = optional_param('itemid', null, PARAM_INT);
$itemtype = optional_param('item', $defaulttype, PARAM_TEXT); $itemtype = optional_param('item', $defaulttype, PARAM_TEXT);
$page = optional_param('page', 0, PARAM_INT); $page = optional_param('page', 0, PARAM_INT);
$perpage = optional_param('perpage', 100, PARAM_INT); $perpage = optional_param('perpage', 100, PARAM_INT);
if ($itemid < 1){ if (empty($itemid)) {
$itemid = $userid; $itemid = $userid;
$itemtype = $defaulttype; $itemtype = $defaulttype;
} }