MDL-45320 behat: Step definitions for blocks

This commit is contained in:
Marina Glancy 2014-05-04 12:44:27 +08:00
parent e3353f92fc
commit a33bc20d2e
5 changed files with 24 additions and 38 deletions

View file

@ -83,13 +83,13 @@ class behat_blocks extends behat_base {
public function i_open_the_blocks_action_menu($blockname) {
if (!$this->running_javascript()) {
throw new DriverException('Blocks action menu not available when Javascript is disabled');
// Action menu does not need to be open if Javascript is off.
return;
}
// If it is already opened we do nothing.
$blocknode = $this->get_block_node($blockname);
$classes = array_flip(explode(' ', $blocknode->getAttribute('class')));
if (!empty($classes['action-menu-shown'])) {
$blocknode = $this->get_text_selector_node('block', $blockname);
if ($blocknode->hasClass('action-menu-shown')) {
return;
}
@ -97,18 +97,18 @@ class behat_blocks extends behat_base {
}
/**
* Returns the DOM node of the block from <div>.
* Clicks on Configure block for specified block. Page must be in editing mode.
*
* @throws ElementNotFoundException Thrown by behat_base::find
* @param string $blockname The block name
* @return NodeElement
* Argument block_name may be either the name of the block or CSS class of the block.
*
* @Given /^I configure the "(?P<block_name_string>(?:[^"]|\\")*)" block$/
* @param string $blockname
*/
protected function get_block_node($blockname) {
$blockname = $this->getSession()->getSelectorsHandler()->xpathLiteral($blockname);
$xpath = "//div[contains(concat(' ', normalize-space(@class), ' '), ' block ')][contains(., $blockname)]";
return $this->find('xpath', $xpath);
public function i_configure_the_block($blockname) {
// Note that since $blockname may be either block name or CSS class, we can not use the exact label of "Configure" link.
return array(
new Given('I open the "'.$this->escape($blockname).'" blocks action menu'),
new Given('I click on "Configure" "link" in the "'.$this->escape($blockname).'" "block"')
);
}
}

View file

@ -4,7 +4,6 @@ Feature: Add and configure blocks throughout the site
As a manager
I need to set and configure blocks throughout the site
@javascript
Scenario: Add and configure a block throughtout the site
Given the following "courses" exists:
| fullname | shortname | category |
@ -18,8 +17,7 @@ Feature: Add and configure blocks throughout the site
And I log in as "manager1"
And I follow "Turn editing on"
And I add the "Comments" block
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Page contexts | Display throughout the entire site |
And I press "Save changes"
@ -27,8 +25,7 @@ Feature: Add and configure blocks throughout the site
Then I should see "Comments" in the "Comments" "block"
And I should see "Save comment" in the "Comments" "block"
And I am on homepage
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Default weight | -10 (first) |
And I press "Save changes"

View file

@ -39,19 +39,16 @@ Feature: Block appearances
And I follow "Course 1"
And I follow "Turn editing on"
And I add the "Comments" block
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Display on page types | Any page |
And I press "Save changes"
@javascript
Scenario: Block settings can be modified so that a block apprears on any page
When I follow "Test survey name"
Then I should see "Comments" in the "Comments" "block"
And I follow "Course 1"
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Display on page types | Any course page |
And I press "Save changes"
@ -59,11 +56,9 @@ Feature: Block appearances
And I follow "Test survey name"
And I should not see "Comments"
@javascript
Scenario: Block settings can be modified so that a block can be hidden or moved
When I follow "Test book name"
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Visible | No |
And I press "Save changes"
@ -72,8 +67,7 @@ Feature: Block appearances
Then I should not see "Comments"
And I expand "Course administration" node
And I follow "Turn editing on"
And I open the "Comments" blocks action menu
And I follow "Configure Comments block"
And I configure the "Comments" block
And I fill the moodle form with:
| Visible | Yes |
| Region | Right |

View file

@ -15,7 +15,6 @@ Feature: Allowed blocks controls
| user | course | role |
| teacher1 | C1 | editingteacher |
@javascript
Scenario: Blocks can be added with the default permissions
Given I log in as "teacher1"
And I follow "Course 1"

View file

@ -4,7 +4,6 @@ Feature: The context of a block can always be returned to it's original state.
As an admin
I need to be able to return the block to original state
@javascript
Scenario: Add and configure a block to display on every page and revert back
Given the following "courses" exists:
| fullname | shortname | category |
@ -15,8 +14,7 @@ Feature: The context of a block can always be returned to it's original state.
And I add the "Tags" block
Then I should see "Tags" in the "Tags" "block"
And I click on "Participants" "link" in the "//li[p/span[contains(normalize-space(string(.)), 'Current course')]]" "xpath_element"
And I open the "Tags" blocks action menu
And I follow "Configure Tags block"
And I configure the "Tags" block
And I fill the moodle form with:
| Display on page types | Any page |
And I press "Save changes"
@ -25,8 +23,7 @@ Feature: The context of a block can always be returned to it's original state.
| Assignment name | Assignment1 |
| Description | Description |
And I follow "Assignment1"
And I open the "Tags" blocks action menu
And I follow "Configure Tags block"
And I configure the "Tags" block
And I fill the moodle form with:
| Display on page types | Any assignment module page |
And I press "Save changes"
@ -41,8 +38,7 @@ Feature: The context of a block can always be returned to it's original state.
| Description | Description |
And I follow "Assignment2"
And I should see "Tags" in the "Tags" "block"
And I open the "Tags" blocks action menu
And I follow "Configure Tags block"
And I configure the "Tags" block
And I fill the moodle form with:
| Display on page types | Any page |
And I press "Save changes"