moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 17:06:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-39572: Fix sql_order_by_text() to use length argument correctly

Browse source
This commit is contained in:
Simon Coggins 2013-08-15 11:54:19 +12:00
parent f6868f9c9d
commit a6bc89e4d2
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/dml/mssql_native_moodle_database.php
View file

@ -1218,7 +1218,7 @@ class mssql_native_moodle_database extends moodle_database {
} }
public function sql_order_by_text($fieldname, $numchars=32) { public function sql_order_by_text($fieldname, $numchars=32) {
return ' CONVERT(varchar, ' . $fieldname . ', ' . $numchars . ')'; return " CONVERT(varchar({$numchars}), {$fieldname})";
} }
/** /**

2
lib/dml/sqlsrv_native_moodle_database.php
View file

@ -1281,7 +1281,7 @@ class sqlsrv_native_moodle_database extends moodle_database {
} }
public function sql_order_by_text($fieldname, $numchars = 32) { public function sql_order_by_text($fieldname, $numchars = 32) {
return ' CONVERT(varchar, '.$fieldname.', '.$numchars.')'; return " CONVERT(varchar({$numchars}), {$fieldname})";
} }
/** /**