moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix SQL query that didn't work in PG (bug 4989)

Browse source
This commit is contained in:
gbateson 2006-03-29 05:14:49 +00:00
parent e989c7699a
commit a83f9d2264
1 changed files with 26 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

42
mod/hotpot/db/update_to_v2.php
View file

@ -58,32 +58,38 @@ function hotpot_update_to_v2_1_6() {
function hotpot_update_to_v2_1_2() { function hotpot_update_to_v2_1_2() {
global $CFG, $db; global $CFG, $db;
$ok = true; $ok = true;
// hotpot_attempts: make sure there is only one "in progress" attempt by each user on each hotpot (and it must be the most recent attempt)
// get info about attempts (grouped by user and hotpot) // save and switch off SQL message echo
// countrecords : number of attempts in the group $debug = $db->debug;
// maxtimestart : most recent timestart in the group $db->debug = false;
// minstatus : minimum status in the group
// (groups with only one attempt, or no "in progess" attempt are ignored) // extract info about attempts by each user on each hotpot (cases where
$records = get_records_sql(" // the user has only one attempt, or no "in progess" attempt are ignored)
SELECT id, userid, hotpot, COUNT(*) as countrecords, MAX(timestart) AS maxtimestart, MIN(status) as minstatus $rs = $db->Execute("
SELECT userid, hotpot, COUNT(*), MIN(status)
FROM {$CFG->prefix}hotpot_attempts FROM {$CFG->prefix}hotpot_attempts
GROUP BY userid, hotpot GROUP BY userid, hotpot
HAVING countrecords > 1 AND minstatus=1 HAVING COUNT(*)>1 AND MIN(status)=1
"); ");
if ($records) { if ($rs && $rs->RecordCount()) {
// save and switch off SQL message echo $records = $rs->GetArray();
$debug = $db->debug;
$db->debug = false; // start message to browser
print "adjusting status of ".count($records)." "in progress" attempts ... "; print "adjusting status of ".count($records)." "in progress" attempts ... ";
// loop through records
foreach ($records as $record) { foreach ($records as $record) {
// get all attempts by this user at this hotpot // get all attempts by this user at this hotpot
$attempts = get_records_sql(" $attempts = get_records_sql("
SELECT id, userid, hotpot, score, timestart, timefinish, status SELECT id, userid, hotpot, score, timestart, timefinish, status
FROM {$CFG->prefix}hotpot_attempts FROM {$CFG->prefix}hotpot_attempts
WHERE userid = $record->userid AND hotpot=$record->hotpot WHERE userid = ".$record['userid']." AND hotpot=".$record['hotpot']."
ORDER BY timestart DESC, id DESC ORDER BY timestart DESC, id DESC
"); ");
unset($previous_timestart); unset($previous_timestart);
foreach ($attempts as $attempt) { foreach ($attempts as $attempt) {
// if this attempt has a status of "in progress" and is not // if this attempt has a status of "in progress" and is not
// the most recent one in the group, set the status to "abandoned" // the most recent one in the group, set the status to "abandoned"
@ -102,11 +108,15 @@ function hotpot_update_to_v2_1_2() {
$previous_timestart = $attempt->timestart; $previous_timestart = $attempt->timestart;
} // end foreach $attempts } // end foreach $attempts
} // end foreach $records } // end foreach $records
// finish message to browser
print $ok ? get_string('success') : 'failed'; print $ok ? get_string('success') : 'failed';
print "<br />\n"; print "<br />\n";
// restore SQL message echo setting
$db->debug = $debug;
} }
// restore SQL message echo setting
$db->debug = $debug;
return $ok; return $ok;
} }
function hotpot_update_to_v2_1() { function hotpot_update_to_v2_1() {