moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-09 10:56:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-66665 assign: Check whether a modified user could actually grade

Browse source
This commit is contained in:
Peter Dias 2020-07-23 20:00:36 +08:00
parent 89d8f73703
commit a8cdc38272
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
mod/assign/locallib.php
View file

@ -5338,12 +5338,22 @@ class assign {
$gradefordisplay = $this->display_grade($gradebookgrade->grade, false); $gradefordisplay = $this->display_grade($gradebookgrade->grade, false);
} }
$gradeddate = $gradebookgrade->dategraded; $gradeddate = $gradebookgrade->dategraded;
// Only display the grader if it is in the right state.
if (in_array($gradingstatus, [ASSIGN_GRADING_STATUS_GRADED, ASSIGN_MARKING_WORKFLOW_STATE_RELEASED])){
if (isset($grade->grader) && $grade->grader > 0) { if (isset($grade->grader) && $grade->grader > 0) {
$grader = $DB->get_record('user', array('id' => $grade->grader)); $grader = $DB->get_record('user', array('id' => $grade->grader));
} else if (isset($gradebookgrade->usermodified) && $gradebookgrade->usermodified > 0) { } else if (isset($gradebookgrade->usermodified)
&& $gradebookgrade->usermodified > 0
&& has_capability('mod/assign:grade', $this->get_context(), $gradebookgrade->usermodified)) {
// Grader not provided. Check that usermodified is a user who can grade.
// Case 1: When an assignment is reopened an empty assign_grade is created so the feedback
// plugin can know which attempt it's referring to. In this case, usermodifed is a student.
// Case 2: When an assignment's grade is overrided via the gradebook, usermodified is a grader
$grader = $DB->get_record('user', array('id' => $gradebookgrade->usermodified)); $grader = $DB->get_record('user', array('id' => $gradebookgrade->usermodified));
} }
} }
}
$viewfullnames = has_capability('moodle/site:viewfullnames', $this->get_context()); $viewfullnames = has_capability('moodle/site:viewfullnames', $this->get_context());