moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-11 20:06:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-79062 gradereport_grader: Remove setting of tabindex >= 1

Browse source 
Tab indices that are greater than or equal to 1 break the natural
tab order of the document and may cause problems for keyboard users.
This commit is contained in:
Jun Pataleta 2023-10-10 13:56:54 +08:00
parent 859df15e73
commit ab08ac740c
No known key found for this signature in database
GPG key ID: F83510526D99E2C7
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
grade/report/grader/lib.php
View file

@ -771,8 +771,6 @@ class grade_report_grader extends grade_report {
$rows = [];
$this->rowcount = 0;
$numusers = count($this->users);
$gradetabindex = 1;
$strgrade = get_string('gradenoun');
$this->get_sort_arrows();
@ -789,14 +787,11 @@ class grade_report_grader extends grade_report {
// Preload scale objects for items with a scaleid and initialize tab indices.
$scaleslist = [];
$tabindices = [];
foreach ($this->gtree->get_items() as $itemid => $item) {
if (!empty($item->scaleid)) {
$scaleslist[] = $item->scaleid;
}
$tabindices[$item->id]['grade'] = $gradetabindex;
$gradetabindex += $numusers * 2;
}
$cache = \cache::make_from_params(\cache_store::MODE_REQUEST, 'gradereport_grader', 'scales');
@ -1061,7 +1056,6 @@ class grade_report_grader extends grade_report {
$nogradestr = get_string('nooutcome', 'grades');
}
$attributes = [
'tabindex' => $tabindices[$item->id]['grade'],
'id' => 'grade_' . $userid . '_' . $item->id
];
$gradelabel = $fullname . ' ' . $item->get_name(true);
@ -1101,7 +1095,6 @@ class grade_report_grader extends grade_report {
$context->value = $value;
$context->label = get_string('useractivitygrade', 'gradereport_grader', $gradelabel);
$context->title = $strgrade;
$context->tabindex = $tabindices[$item->id]['grade'];
$context->extraclasses = 'form-control';
if ($context->statusicons) {
$context->extraclasses .= ' statusicons';

2
grade/templates/grades/grader/input.mustache
View file

@ -31,4 +31,4 @@
}
}}
<label for="{{id}}" class="accesshide">{{{label}}}</label>
<input id="{{id}}" name="{{name}}" type="text" value="{{value}}" title="{{title}}" class="{{extraclasses}}" tabindex="{{tabindex}}">
<input id="{{id}}" name="{{name}}" type="text" value="{{value}}" title="{{title}}" class="{{extraclasses}}">