moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-70173 dashboard: ARIA role presentation conflicted the empty alt

Browse source 
The markup <img role="presentation" alt="alt text"> is contradictory.

According to https://www.w3.org/TR/2017/WD-wai-aria-practices-1.1-20170628/examples/presentation/PresentationRoleExamples.html
 It is recommended that authors instead use empty alt text (alt="")
 where they use role="presentation".
This commit is contained in:
Shamim Rezaie 2020-12-07 01:43:45 +11:00
parent 30354e039a
commit ac4b7f1193
3 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
blocks/recentlyaccessedcourses/templates/recentlyaccessedcourses-view.mustache
View file

@ -45,8 +45,7 @@
<div class="hidden text-xs-center text-center mt-3" data-region="empty-message"> <div class="hidden text-xs-center text-center mt-3" data-region="empty-message">
<img class="empty-placeholder-image-lg mt-1" <img class="empty-placeholder-image-lg mt-1"
src="{{nocoursesimgurl}}" src="{{nocoursesimgurl}}"
alt="{{#str}} nocourses, block_recentlyaccessedcourses {{/str}}" alt="">
role="presentation">
<p class="text-muted mt-3">{{#str}} nocourses, block_recentlyaccessedcourses {{/str}}</p> <p class="text-muted mt-3">{{#str}} nocourses, block_recentlyaccessedcourses {{/str}}</p>
</div> </div>
</div> </div>

3
blocks/timeline/templates/event-list.mustache
View file

@ -46,8 +46,7 @@
<div class="hidden text-xs-center text-center mt-3" data-region="empty-message"> <div class="hidden text-xs-center text-center mt-3" data-region="empty-message">
<img <img
src="{{urls.noevents}}" src="{{urls.noevents}}"
alt="{{#str}} noevents, block_timeline {{/str}}" alt=""
role="presentation"
style="height: 70px; width: 70px" style="height: 70px; width: 70px"
> >
<p class="text-muted mt-1">{{#str}} noevents, block_timeline {{/str}}</p> <p class="text-muted mt-1">{{#str}} noevents, block_timeline {{/str}}</p>

3
blocks/timeline/templates/view-courses.mustache
View file

@ -41,8 +41,7 @@
<div class="hidden text-xs-center text-center mt-3" data-region="no-courses-empty-message"> <div class="hidden text-xs-center text-center mt-3" data-region="no-courses-empty-message">
<img <img
src="{{urls.noevents}}" src="{{urls.noevents}}"
alt="{{#str}} nocoursesinprogress, block_timeline {{/str}}" alt=""
role="presentation"
style="height: 70px; width: 70px" style="height: 70px; width: 70px"
> >
<p class="text-muted mt-1">{{#str}} nocoursesinprogress, block_timeline {{/str}}</p> <p class="text-muted mt-1">{{#str}} nocoursesinprogress, block_timeline {{/str}}</p>