MDL-82207 phpunit: fix various @covers annotations (take#1)

This fixes various (not all) wrong @covers annotations that
are reported as warnings by PHPUnit when it's run with
code-coverage enabled.

When possible, the preferred solution is to change to
@covers at class level, that is the recommended way.

If multiple classes are involved, then a mix of @coversDefaultClass
and @covers at method level are used (always trying to use the
minimum needed patch).

This is the first of a series of issues created as sub-tasks
of MDL-82142.
This commit is contained in:
Eloy Lafuente (stronk7) 2024-06-17 18:07:47 +02:00
parent ad7fc69c25
commit ad5fe71868
No known key found for this signature in database
GPG key ID: 53487A05E6228820
53 changed files with 75 additions and 128 deletions

View file

@ -40,7 +40,6 @@ class base_test extends advanced_testcase {
* Tests the save and load functionality.
*
* @author Jason den Dulk
* @covers \core_courseformat
*/
public function test_courseformat_saveandload(): void {
$this->resetAfterTest();

View file

@ -22,7 +22,7 @@ namespace core_courseformat;
* @package core_courseformat
* @copyright 2023 Ferran Recio <ferran@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @coversDefaultClass \core_courseformat\base
* @coversDefaultClass \core_courseformat\formatactions
*/
class formatactions_test extends \advanced_testcase {

View file

@ -25,7 +25,7 @@ use cm_info;
* @package core_courseformat
* @copyright 2023 Ferran Recio <ferran@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @coversDefaultClass \core_courseformat\base
* @coversDefaultClass \core_courseformat\local\baseactions
*/
class baseactions_test extends \advanced_testcase {
/**

View file

@ -24,7 +24,7 @@ use core_courseformat\hook\after_cm_name_edited;
* @package core_courseformat
* @copyright 2024 Ferran Recio <ferran@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @coversDefaultClass \core_courseformat\cmactions
* @coversDefaultClass \core_courseformat\local\cmactions
*/
final class cmactions_test extends \advanced_testcase {
/**

View file

@ -24,7 +24,7 @@ use stdClass;
* @package core_courseformat
* @copyright 2023 Ferran Recio <ferran@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @coversDefaultClass \core_courseformat\sectionactions
* @coversDefaultClass \core_courseformat\local\sectionactions
*/
class sectionactions_test extends \advanced_testcase {
/**

View file

@ -41,7 +41,9 @@ class state_test extends \advanced_testcase {
* Test the behaviour of state::export_for_template().
*
* @dataProvider state_provider
* @covers \core_courseformat\output\local\state
* @covers \core_courseformat\output\local\state\course
* @covers \core_courseformat\output\local\state\section
* @covers \core_courseformat\output\local\state\cm
*
* @param string $format The course format of the course where the method will be executed.
*/

View file

@ -575,7 +575,9 @@ class restore_test extends \advanced_testcase {
* Tests course restore with editor in course format.
*
* @author Matthew Hilton
* @covers \core_courseformat
* @covers \core_courseformat\base
* @covers \backup_course_structure_step
* @covers \restore_course_structure_step
*/
public function test_restore_editor_courseformat(): void {
$this->resetAfterTest();

View file

@ -21,6 +21,7 @@
* @subpackage course
* @copyright 2021 Tomo Tsuyuki <tomotsuyuki@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @covers \core_course\task\course_delete_modules
*/
namespace core_course;
@ -68,8 +69,6 @@ class course_delete_modules_test extends \advanced_testcase {
/**
* Test with failed and successful cms
*
* @covers ::course_delete_modules
*/
public function test_delete_module_exception(): void {
global $DB;