moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-59691 assignfeedback_editpdf: Allow comments to collapse to top-left

Browse source 
Forcing them to collapse to the bottom-left corner seems less natural
and effectively changes the location of existing comments from pre-3.3
This commit is contained in:
Tony Butler 2017-08-02 15:43:47 +01:00
parent 2bd2660751
commit ad7c719de4
4 changed files with 8 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-debug.js vendored
View file

@ -2592,11 +2592,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px', 'height': scrollheight + 'px',
'overflow': 'hidden' 'overflow': 'hidden'
}); });
marker.setStyles({ marker.setStyle('color', COMMENTCOLOUR[this.colour]);
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
this.attach_events(node, menu); this.attach_events(node, menu);
if (focus) { if (focus) {
node.focus(); node.focus();

10
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-min.js vendored
View file

File diff suppressed because one or more lines are too long

6
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor.js vendored
View file

@ -2592,11 +2592,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px', 'height': scrollheight + 'px',
'overflow': 'hidden' 'overflow': 'hidden'
}); });
marker.setStyles({ marker.setStyle('color', COMMENTCOLOUR[this.colour]);
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
this.attach_events(node, menu); this.attach_events(node, menu);
if (focus) { if (focus) {
node.focus(); node.focus();

6
mod/assign/feedback/editpdf/yui/src/editor/js/comment.js vendored
View file

@ -215,11 +215,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px', 'height': scrollheight + 'px',
'overflow': 'hidden' 'overflow': 'hidden'
}); });
marker.setStyles({ marker.setStyle('color', COMMENTCOLOUR[this.colour]);
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
this.attach_events(node, menu); this.attach_events(node, menu);
if (focus) { if (focus) {
node.focus(); node.focus();