moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 09:26:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-78324 badges: Remove unnecessary Modal

Browse source 
The core/utility confirmation modal can be used in this case to confirm
backpack actions. It is not necessary to have a custom module for this
purpose.
This commit is contained in:
Andrew Nicols 2023-05-23 21:42:43 +08:00
parent 96e32d6f90
commit adce2874b0
No known key found for this signature in database
GPG key ID: 6D1E3157C8CFBF14
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
badges/classes/output/external_backpacks_page.php
View file

@ -64,8 +64,6 @@ class external_backpacks_page implements \renderable {
public function export_for_template(\renderer_base $output) { public function export_for_template(\renderer_base $output) {
global $PAGE; global $PAGE;
$PAGE->requires->js_call_amd('core_badges/backpackactions', 'init');
$rownumber = 0; $rownumber = 0;
$rowcount = count($this->backpacks); $rowcount = count($this->backpacks);

11
badges/templates/external_backpacks_page.mustache
View file

@ -71,7 +71,16 @@
<td> <td>
<a href="{{baseurl}}?id={{id}}&action=edit">{{#pix}}t/edit, core,{{#str}}editsettings{{/str}}{{/pix}}</a> <a href="{{baseurl}}?id={{id}}&action=edit">{{#pix}}t/edit, core,{{#str}}editsettings{{/str}}{{/pix}}</a>
{{^sitebackpack}} {{^sitebackpack}}
<a href="{{baseurl}}?id={{id}}&action=delete" role="button" data-action="deletebackpack"> <a {{!
}} href="{{baseurl}}?id={{id}}&action=delete" {{!
}} role="button" {{!
}} data-modal="confirmation" {{!
}} data-modal-type="delete" {{!
}} data-modal-content-str='["delexternalbackpackconfirm", "core_badges", {{#quote}}{{backpackweburl}}{{/quote}}]' {{!
}} data-modal-title-str='["delexternalbackpack", "core_badges"]' {{!
}} data-modal-yes-button-str='["delete", "core"]' {{!
}} data-modal-destination="{{baseurl}}?id={{id}}&action=delete&sesskey={{sesskey}}&confirm=1" {{!
}}>
{{#pix}}t/delete, core,{{#str}}delete{{/str}}{{/pix}} {{#pix}}t/delete, core,{{#str}}delete{{/str}}{{/pix}}
</a> </a>
{{/sitebackpack}} {{/sitebackpack}}