From ae3e9667c2943e02fb9554e95ec756c480e6faae Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Thu, 30 Mar 2023 13:00:39 +0800 Subject: [PATCH] MDL-72350 core: Add @covers for test_check_mod_assignment_is_used Plus, remove getStatus() assertion when running the test with mod_assignment reinstalled since it check_mod_assignment returns a null result. --- lib/tests/upgradelib_test.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tests/upgradelib_test.php b/lib/tests/upgradelib_test.php index f201caa8cc0..4595477ab43 100644 --- a/lib/tests/upgradelib_test.php +++ b/lib/tests/upgradelib_test.php @@ -1357,6 +1357,7 @@ class upgradelib_test extends advanced_testcase { /** * Test the check_mod_assignment check if mod_assignment is still used. * + * @covers ::check_mod_assignment * @return void */ public function test_check_mod_assignment_is_used(): void { @@ -1368,7 +1369,6 @@ class upgradelib_test extends advanced_testcase { if (file_exists("{$CFG->dirroot}/mod/assignment/version.php")) { // This is for when the test is run on sites where mod_assignment is most likely reinstalled. $this->assertNull(check_mod_assignment($result)); - $this->assertTrue($result->getStatus()); } else { // This is for when the test is run on sites with mod_assignment now gone. $this->assertFalse($DB->get_manager()->table_exists('assignment'));