MDL-39430 phpunit: skip unmet optional environment checks

This commit is contained in:
Sam Hemelryk 2013-07-31 10:46:44 +12:00
parent 6867a78d75
commit b05cfa0e67

View file

@ -31,6 +31,11 @@ defined('MOODLE_INTERNAL') || die();
*/
class core_environment_testcase extends advanced_testcase {
/**
* Test the environment.
*
* @todo MDL-40952 will introduce a way to output something to the user to inform them this has failed.
*/
public function test_environment() {
global $CFG;
@ -39,6 +44,13 @@ class core_environment_testcase extends advanced_testcase {
$this->assertNotEmpty($envstatus);
foreach ($environment_results as $environment_result) {
if ($environment_result->getLevel() === 'optional' && $environment_result->getStatus() === false) {
// An optional environment test has failed, we don't want to fail unit tests because of this.
// This was first detected with the opcache notice, see the to do in the phpdoc.
// We are going to fake the assertion count here so that people get consistent numbers.
$this->addToAssertionCount(1);
continue;
}
$this->assertTrue($environment_result->getStatus(), "Problem detected in environment ($environment_result->part:$environment_result->info), fix all warnings and errors!");
}
}