mirror of
https://github.com/moodle/moodle.git
synced 2025-08-05 17:06:53 +02:00
MDL-39430 phpunit: skip unmet optional environment checks
This commit is contained in:
parent
6867a78d75
commit
b05cfa0e67
1 changed files with 12 additions and 0 deletions
|
@ -31,6 +31,11 @@ defined('MOODLE_INTERNAL') || die();
|
|||
*/
|
||||
class core_environment_testcase extends advanced_testcase {
|
||||
|
||||
/**
|
||||
* Test the environment.
|
||||
*
|
||||
* @todo MDL-40952 will introduce a way to output something to the user to inform them this has failed.
|
||||
*/
|
||||
public function test_environment() {
|
||||
global $CFG;
|
||||
|
||||
|
@ -39,6 +44,13 @@ class core_environment_testcase extends advanced_testcase {
|
|||
|
||||
$this->assertNotEmpty($envstatus);
|
||||
foreach ($environment_results as $environment_result) {
|
||||
if ($environment_result->getLevel() === 'optional' && $environment_result->getStatus() === false) {
|
||||
// An optional environment test has failed, we don't want to fail unit tests because of this.
|
||||
// This was first detected with the opcache notice, see the to do in the phpdoc.
|
||||
// We are going to fake the assertion count here so that people get consistent numbers.
|
||||
$this->addToAssertionCount(1);
|
||||
continue;
|
||||
}
|
||||
$this->assertTrue($environment_result->getStatus(), "Problem detected in environment ($environment_result->part:$environment_result->info), fix all warnings and errors!");
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue