Fixed Bugs #1059 and #1061.

This commit is contained in:
rkingdon 2004-03-12 15:28:52 +00:00
parent 2f39268b3d
commit b082b2c641
2 changed files with 39 additions and 36 deletions

View file

@ -2095,6 +2095,7 @@ function workshop_list_student_submissions($workshop, $user) {
$nassessments[$submission->id] = $n + rand(0, 98) / 100; $nassessments[$submission->id] = $n + rand(0, 98) / 100;
} }
if (isset($nassessments)) { // make sure we end up with something to play with :-)
// put the submissions with the lowest number of assessments first // put the submissions with the lowest number of assessments first
asort($nassessments); asort($nassessments);
reset($nassessments); reset($nassessments);
@ -2130,8 +2131,9 @@ function workshop_list_student_submissions($workshop, $user) {
} }
} }
} }
// now list the student submissions this user has been allocated, list only the hot and warm ones, the cold ones }
// are listed in the "your assessments list" (_list_assessed submissions) // now list the student submissions this user has been allocated, list only the hot and warm ones,
// the cold ones are listed in the "your assessments list" (_list_assessed submissions)
if ($assessments = workshop_get_user_assessments($workshop, $user)) { if ($assessments = workshop_get_user_assessments($workshop, $user)) {
$timenow = time(); $timenow = time();
foreach ($assessments as $assessment) { foreach ($assessments as $assessment) {

View file

@ -1025,6 +1025,7 @@
} }
} }
else { // funny this user did not submit - create a dummy submission to hold any grades they might have else { // funny this user did not submit - create a dummy submission to hold any grades they might have
unset($bestsubmission);
$bestsubmission->workshopid = $workshop->id; $bestsubmission->workshopid = $workshop->id;
$bestsubmission->userid = $user->id; $bestsubmission->userid = $user->id;
$bestsubmission->title = "No Submission"; $bestsubmission->title = "No Submission";