moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-12373 - More instances of links to the participants list being shown in the navigation bar to people without the necessary capability.

Browse source 
I have not copied and pasted the same code into lots of different places. That sucks. We really need to refactor this into a function that builds the navigation up to, and including the user's name. However, I don't have time now. A list of the places touched by this bug (MDL-12373) will at least give a complete list of places that such a refactoring would have to touch.
This commit is contained in:
tjhunt 2008-01-10 10:58:16 +00:00
parent d1a2a97ba3
commit b26adbef4c
9 changed files with 41 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
notes/edit.php
View file

@ -36,7 +36,7 @@
/// get option values for the user select
/// create form
$noteform = new note_edit_form(null);
$noteform = new note_edit_form();
/// if form was cancelled then return to the notes list of the note
if ($noteform->is_cancelled()) {
@ -72,7 +72,9 @@
/// output HTML
$nav = array();
$nav[] = array('name' => get_string('participants'), 'link' => $CFG->wwwroot . '/user/index.php?id=' . $course->id, 'type' => 'misc');
if (has_capability('moodle/course:viewparticipants', $context) || has_capability('moodle/site:viewparticipants', get_context_instance(CONTEXT_SYSTEM))) {
$nav[] = array('name' => get_string('participants'), 'link' => $CFG->wwwroot . '/user/index.php?id=' . $course->id, 'type' => 'misc');
}
$nav[] = array('name' => fullname($user), 'link' => $CFG->wwwroot . '/user/view.php?id=' . $user->id. '&course=' . $course->id, 'type' => 'misc');
$nav[] = array('name' => get_string('notes', 'notes'), 'link' => $CFG->wwwroot . '/notes/index.php?course=' . $course->id . '&user=' . $user->id, 'type' => 'misc');
$nav[] = array('name' => $strnotes, 'link' => '', 'type' => 'activity');