moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Block now works as it intuitively should in separate groups mode as well.

Browse source 
For editing teachers, it shows separategroups as visiblegroups.
This commit is contained in:
defacer 2005-01-27 17:40:46 +00:00
parent 84bbe7f9d3
commit b35bc4d8db
1 changed files with 33 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

38
blocks/quiz_results/block_quiz_results.php
View file

@ -76,10 +76,14 @@ class block_quiz_results extends block_base {
// The actual groupmode for the quiz is now known to be $groupmode // The actual groupmode for the quiz is now known to be $groupmode
} }
if($groupmode != NOGROUPS) { if(isteacheredit($courseid) && $groupmode == SEPARATEGROUPS) {
// Group mode // We 'll make an exception in this case
$groupmode = VISIBLEGROUPS;
}
// Pull out the course groups switch($groupmode) {
case VISIBLEGROUPS:
// Display group-mode results
$groups = get_groups($courseid); $groups = get_groups($courseid);
if(empty($groups)) { if(empty($groups)) {
@ -192,10 +196,33 @@ class block_quiz_results extends block_base {
} }
$this->content->text .= '</tbody></table>'; $this->content->text .= '</tbody></table>';
} }
break;
case SEPARATEGROUPS:
// This is going to be just like no-groups mode, only we 'll filter
// out the grades from people not in our group.
if(empty($USER) || empty($USER->id)) {
// Not logged in, so show nothing
return $this->content;
} }
$mygroups = get_groups($courseid, $USER->id);
if(empty($mygroups)) {
// Not member of a group, show nothing
return $this->content;
}
else { $mygroupsusers = get_records_list('groups_members', 'groupid', implode(',', array_keys($mygroups)), '', 'userid, id');
// There should be at least one user there, ourselves. So no more tests.
// Just filter out the grades belonging to other users, and proceed as if there were no groups
$strallowedusers = implode(',', array_keys($mygroupsusers));
$grades = array_filter($grades, create_function('$el', '$allowed = explode(",", "'.$strallowedusers.'"); return in_array($el->userid, $allowed);'));
// NO break; HERE, JUST GO AHEAD
default:
case NOGROUPS:
// Single user mode // Single user mode
$numbest = empty($this->config->showbest) ? 0 : min($this->config->showbest, count($grades)); $numbest = empty($this->config->showbest) ? 0 : min($this->config->showbest, count($grades));
$numworst = empty($this->config->showworst) ? 0 : min($this->config->showworst, count($grades) - $numbest); $numworst = empty($this->config->showworst) ? 0 : min($this->config->showworst, count($grades) - $numbest);
@ -274,10 +301,9 @@ class block_quiz_results extends block_base {
} }
$this->content->text .= '</tbody></table>'; $this->content->text .= '</tbody></table>';
} }
break;
} }
return $this->content; return $this->content;
} }