moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 01:16:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-36162 core_message: removed the unnecessary and confusing course URL parameter as well as fixing the broken breadcrumb

Browse source
This commit is contained in:
Andrew Davis 2012-10-22 16:46:39 +08:00
parent 98197952cc
commit b4a8ab2daa
2 changed files with 5 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/navigationlib.php
View file

@ -4194,7 +4194,7 @@ class settings_navigation extends navigation_node {
// Messaging // Messaging
if (($currentuser && has_capability('moodle/user:editownmessageprofile', $systemcontext)) || (!isguestuser($user) && has_capability('moodle/user:editmessageprofile', $usercontext) && !is_primary_admin($user->id))) { if (($currentuser && has_capability('moodle/user:editownmessageprofile', $systemcontext)) || (!isguestuser($user) && has_capability('moodle/user:editmessageprofile', $usercontext) && !is_primary_admin($user->id))) {
$url = new moodle_url('/message/edit.php', array('id'=>$user->id, 'course'=>$course->id)); $url = new moodle_url('/message/edit.php', array('id'=>$user->id));
$usersetting->add(get_string('editmymessage', 'message'), $url, self::TYPE_SETTING); $usersetting->add(get_string('editmymessage', 'message'), $url, self::TYPE_SETTING);
} }

34
message/edit.php
View file

@ -26,30 +26,14 @@ require_once(dirname(__FILE__) . '/../config.php');
require_once($CFG->dirroot . '/message/lib.php'); require_once($CFG->dirroot . '/message/lib.php');
$userid = optional_param('id', $USER->id, PARAM_INT); // user id $userid = optional_param('id', $USER->id, PARAM_INT); // user id
$course = optional_param('course', SITEID, PARAM_INT); // course id (defaults to Site)
$disableall = optional_param('disableall', 0, PARAM_BOOL); //disable all of this user's notifications $disableall = optional_param('disableall', 0, PARAM_BOOL); //disable all of this user's notifications
$url = new moodle_url('/message/edit.php'); $url = new moodle_url('/message/edit.php');
$url->param('id', $userid); $url->param('id', $userid);
$url->param('course', $course);
$PAGE->set_url($url); $PAGE->set_url($url);
if (!$course = $DB->get_record('course', array('id' => $course))) { require_login();
print_error('invalidcourseid');
}
if ($course->id != SITEID) {
require_login($course);
} else {
if (!isloggedin()) {
if (empty($SESSION->wantsurl)) {
$SESSION->wantsurl = $CFG->httpswwwroot.'/message/edit.php';
}
redirect(get_login_url());
}
}
if (isguestuser()) { if (isguestuser()) {
print_error('guestnoeditmessage', 'message'); print_error('guestnoeditmessage', 'message');
@ -71,10 +55,6 @@ $PAGE->requires->js_init_call('M.core_message.init_editsettings');
if ($user->id == $USER->id) { if ($user->id == $USER->id) {
//editing own message profile //editing own message profile
require_capability('moodle/user:editownmessageprofile', $systemcontext); require_capability('moodle/user:editownmessageprofile', $systemcontext);
if ($course->id != SITEID && $node = $PAGE->navigation->find($course->id, navigation_node::TYPE_COURSE)) {
$node->make_active();
$PAGE->navbar->includesettingsbase = true;
}
} else { } else {
// teachers, parents, etc. // teachers, parents, etc.
require_capability('moodle/user:editmessageprofile', $personalcontext); require_capability('moodle/user:editmessageprofile', $personalcontext);
@ -144,7 +124,7 @@ if (($form = data_submitted()) && confirm_sesskey()) {
print_error('cannotupdateusermsgpref'); print_error('cannotupdateusermsgpref');
} }
redirect("$CFG->wwwroot/message/edit.php?id=$user->id&course=$course->id"); redirect("$CFG->wwwroot/message/edit.php?id=$user->id");
} }
/// Load preferences /// Load preferences
@ -179,14 +159,8 @@ $preferences->blocknoncontacts = get_user_preferences( 'message_blocknoncontac
/// Display page header /// Display page header
$streditmymessage = get_string('editmymessage', 'message'); $streditmymessage = get_string('editmymessage', 'message');
$strparticipants = get_string('participants'); $PAGE->set_title($streditmymessage);
$PAGE->set_heading($streditmymessage);
$PAGE->set_title("$course->shortname: $streditmymessage");
if ($course->id != SITEID) {
$PAGE->set_heading("$course->fullname: $streditmymessage");
} else {
$PAGE->set_heading($course->fullname);
}
// Grab the renderer // Grab the renderer
$renderer = $PAGE->get_renderer('core', 'message'); $renderer = $PAGE->get_renderer('core', 'message');