moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve save file, showing the proper error if not writeable.

Browse source
This commit is contained in:
stronk7 2006-08-30 17:12:00 +00:00
parent e9d5166a3e
commit b4f3a93b01
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
admin/xmldb/actions/save_xml_file/save_xml_file.class.php
View file

@ -38,7 +38,7 @@ class save_xml_file extends XMLDBAction {
/// Get needed strings /// Get needed strings
$this->loadStrings(array( $this->loadStrings(array(
/// 'key' => 'module' 'filenotwriteable' => 'xmldb'
)); ));
} }
@ -78,6 +78,12 @@ class save_xml_file extends XMLDBAction {
} }
} }
/// Chech for perms
if (!is_writeable($dirpath . '/install.xml')) {
$this->errormsg = $this->str['filenotwriteable'] . '(' . $dirpath . '/install.xml)';
return false;
}
/// Save the original dir /// Save the original dir
$result = $dbdir->xml_file->saveXMLFile(); $result = $dbdir->xml_file->saveXMLFile();
@ -91,7 +97,8 @@ class save_xml_file extends XMLDBAction {
unset($XMLDB->dbdirs[$dirpath]->xml_exists); unset($XMLDB->dbdirs[$dirpath]->xml_exists);
unset($XMLDB->dbdirs[$dirpath]->xml_writeable); unset($XMLDB->dbdirs[$dirpath]->xml_writeable);
} else { } else {
$errormsg = 'Error saving XML file (' . $dirpath . ')'; $this->errormsg = 'Error saving XML file (' . $dirpath . ')';
return false;
} }
/// Launch postaction if exists (leave this here!) /// Launch postaction if exists (leave this here!)