moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-65412 core_customfield: check configdata link exists

Browse source
This commit is contained in:
David Matamoros 2019-04-24 17:30:02 +02:00
parent bc342f101a
commit baf5551cac
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
customfield/field/text/classes/field_controller.php
View file

@ -105,14 +105,16 @@ class field_controller extends \core_customfield\field_controller {
$errors['configdata[displaysize]'] = get_string('errorconfigdisplaysize', 'customfield_text'); $errors['configdata[displaysize]'] = get_string('errorconfigdisplaysize', 'customfield_text');
} }
$link = $data['configdata']['link']; if (isset($data['configdata']['link'])) {
if (strlen($link)) { $link = $data['configdata']['link'];
require_once($CFG->dirroot . '/lib/validateurlsyntax.php'); if (strlen($link)) {
if (strpos($link, '$$') === false) { require_once($CFG->dirroot . '/lib/validateurlsyntax.php');
$errors['configdata[link]'] = get_string('errorconfiglinkplaceholder', 'customfield_text'); if (strpos($link, '$$') === false) {
} else if (!validateUrlSyntax(str_replace('$$', 'XYZ', $link), 's+H?S?F-E-u-P-a?I?p?f?q?r?')) { $errors['configdata[link]'] = get_string('errorconfiglinkplaceholder', 'customfield_text');
// This validation is more strict than PARAM_URL - it requires the protocol and it must be either http or https. } else if (!validateUrlSyntax(str_replace('$$', 'XYZ', $link), 's+H?S?F-E-u-P-a?I?p?f?q?r?')) {
$errors['configdata[link]'] = get_string('errorconfigdisplaysize', 'customfield_text'); // This validation is more strict than PARAM_URL - it requires the protocol and it must be either http or https.
$errors['configdata[link]'] = get_string('errorconfigdisplaysize', 'customfield_text');
}
} }
} }