moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-10890 all require_login() in modules reviewed and fixed use of $cm

Browse source
This commit is contained in:
skodak 2007-08-17 12:49:28 +00:00
parent a104debf4f
commit bb5b72244a
20 changed files with 26 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/chat/gui_header_js/insert.php
View file

@ -18,7 +18,11 @@
error('Could not find the course this belongs to!'); error('Could not find the course this belongs to!');
} }
require_login($course->id); if (!$cm = get_coursemodule_from_instance('chat', $chat->id, $course->id)) {
error('Course Module ID was incorrect');
}
require_login($course->id, false, $cm);
if (isguest()) { if (isguest()) {
error('Guest does not have access to chat rooms'); error('Guest does not have access to chat rooms');

2
mod/data/import.php
View file

@ -57,6 +57,8 @@
} }
} }
require_login($course, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/data:uploadentries', $context); require_capability('mod/data:uploadentries', $context);

2
mod/data/templates.php
View file

@ -26,8 +26,6 @@
require_once('lib.php'); require_once('lib.php');
require_once($CFG->libdir.'/blocklib.php'); require_once($CFG->libdir.'/blocklib.php');
require_login();
$id = optional_param('id', 0, PARAM_INT); // course module id $id = optional_param('id', 0, PARAM_INT); // course module id
$d = optional_param('d', 0, PARAM_INT); // database id $d = optional_param('d', 0, PARAM_INT); // database id
$mode = optional_param('mode', 'singletemplate', PARAM_ALPHA); $mode = optional_param('mode', 'singletemplate', PARAM_ALPHA);

2
mod/glossary/editcategories.php
View file

@ -39,7 +39,7 @@
} }
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/glossary:managecategories', $context); require_capability('mod/glossary:managecategories', $context);

2
mod/glossary/export.php
View file

@ -21,7 +21,7 @@
error("Course module is incorrect"); error("Course module is incorrect");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/glossary:export', $context); require_capability('mod/glossary:export', $context);

2
mod/glossary/exportfile.php
View file

@ -23,7 +23,7 @@
error("Course module is incorrect"); error("Course module is incorrect");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/glossary:export', $context); require_capability('mod/glossary:export', $context);

2
mod/glossary/import.php
View file

@ -27,7 +27,7 @@
error("Course module is incorrect"); error("Course module is incorrect");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/glossary:import', $context); require_capability('mod/glossary:import', $context);

2
mod/hotpot/attempt.php
View file

@ -22,7 +22,7 @@
} }
// make sure this user is enrolled in this course // make sure this user is enrolled in this course
require_login($course->id); require_login($course, true, $cm);
$next_url = "$CFG->wwwroot/course/view.php?id=$course->id"; $next_url = "$CFG->wwwroot/course/view.php?id=$course->id";
$time = time(); $time = time();

2
mod/hotpot/report.php
View file

@ -38,7 +38,7 @@
// set homeurl of couse (for error messages) // set homeurl of couse (for error messages)
$course_homeurl = "$CFG->wwwroot/course/view.php?id=$course->id"; $course_homeurl = "$CFG->wwwroot/course/view.php?id=$course->id";
require_login($course->id); require_login($course, true, $cm);
// get report mode // get report mode
if (has_capability('mod/hotpot:viewreport',$modulecontext)) { if (has_capability('mod/hotpot:viewreport',$modulecontext)) {

3
mod/hotpot/review.php
View file

@ -31,9 +31,10 @@
if (! $attempt = get_record("hotpot_attempts", "id", $attempt)) { if (! $attempt = get_record("hotpot_attempts", "id", $attempt)) {
error("Attempt ID was incorrect"); error("Attempt ID was incorrect");
} }
require_login($course, true, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_login($course->id);
if (!has_capability('mod/hotpot:viewreport',$context)) { if (!has_capability('mod/hotpot:viewreport',$context)) {
if (!$hotpot->review) { if (!$hotpot->review) {
error(get_string("noreview", "quiz")); error(get_string("noreview", "quiz"));

2
mod/hotpot/view.php
View file

@ -34,7 +34,7 @@
} }
} }
require_login($course->id); require_login($course, true, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
} }
// set nextpage (for error messages) // set nextpage (for error messages)

2
mod/journal/report.php
View file

@ -13,7 +13,7 @@
error("Course module is misconfigured"); error("Course module is misconfigured");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
if (!isteacher($course->id)) { if (!isteacher($course->id)) {
error("Only teachers can look at this page"); error("Only teachers can look at this page");

2
mod/lams/view.php
View file

@ -21,7 +21,7 @@ if (! $lams = get_record("lams", "id", $cm->instance)) {
error("Course module is incorrect"); error("Course module is incorrect");
} }
require_login($course->id); require_login($course, true, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
add_to_log($course->id, "lams", "view", "view.php?id=$cm->id", "$lams->id"); add_to_log($course->id, "lams", "view", "view.php?id=$cm->id", "$lams->id");

2
mod/lesson/import.php
View file

@ -28,7 +28,7 @@
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/lesson:edit', $context); require_capability('mod/lesson:edit', $context);

2
mod/lesson/importppt.php
View file

@ -37,7 +37,7 @@
error("Course module is incorrect"); error("Course module is incorrect");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/lesson:edit', $context); require_capability('mod/lesson:edit', $context);

2
mod/lesson/report.php
View file

@ -28,7 +28,7 @@
} }
// make sure people are where they should be // make sure people are where they should be
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/lesson:manage', $context); require_capability('mod/lesson:manage', $context);

4
mod/quiz/comment.php
View file

@ -28,9 +28,9 @@
error('Attempt has not closed yet'); error('Attempt has not closed yet');
} }
require_login($course->id);
$cm = get_coursemodule_from_instance('quiz', $quiz->id); $cm = get_coursemodule_from_instance('quiz', $quiz->id);
require_login($course, true, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/quiz:grade', $context); require_capability('mod/quiz:grade', $context);

2
mod/quiz/report.php
View file

@ -35,7 +35,7 @@
} }
} }
require_login($course->id, false); require_login($course, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);
require_capability('mod/quiz:viewreports', $context); require_capability('mod/quiz:viewreports', $context);

2
mod/survey/download.php
View file

@ -16,7 +16,7 @@
error("Course is misconfigured"); error("Course is misconfigured");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
require_capability('mod/survey:download', get_context_instance(CONTEXT_MODULE, $cm->id)) ; require_capability('mod/survey:download', get_context_instance(CONTEXT_MODULE, $cm->id)) ;
if (! $survey = get_record("survey", "id", $cm->instance)) { if (! $survey = get_record("survey", "id", $cm->instance)) {

2
mod/survey/report.php
View file

@ -23,7 +23,7 @@
error("Course is misconfigured"); error("Course is misconfigured");
} }
require_login($course->id, false); require_login($course->id, false, $cm);
$context = get_context_instance(CONTEXT_MODULE, $cm->id); $context = get_context_instance(CONTEXT_MODULE, $cm->id);