moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 01:16:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "MDL-38555 forms: Prevent same data submission multiple times."

Browse source 
This reverts commit 9f2f313e9f.
This commit is contained in:
Sam Hemelryk 2013-06-12 14:22:01 +12:00
parent 1899145c50
commit c601027d8f
3 changed files with 0 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/form/submit.js
View file

@ -1,9 +0,0 @@
M.form_submit = {};
M.form_submit.init = function(Y, options) {
Y.on('submit', function(e) {
if (!containsErrors) {
e.target.one('#'+options.submitid).setAttribute('disabled', 'true');
}
}, '#'+options.formid);
};

20
lib/form/submit.php
View file

@ -38,9 +38,6 @@ require_once("HTML/QuickForm/submit.php");
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/ */
class MoodleQuickForm_submit extends HTML_QuickForm_submit { class MoodleQuickForm_submit extends HTML_QuickForm_submit {
/** @var string Need to store id of form for submission control in JS*/
var $_formid = '';
/** /**
* constructor * constructor
* *
@ -63,7 +60,6 @@ class MoodleQuickForm_submit extends HTML_QuickForm_submit {
{ {
switch ($event) { switch ($event) {
case 'createElement': case 'createElement':
$this->_formid = $caller->getAttribute('id');
parent::onQuickFormEvent($event, $arg, $caller); parent::onQuickFormEvent($event, $arg, $caller);
if ($caller->isNoSubmitButton($arg[0])){ if ($caller->isNoSubmitButton($arg[0])){
//need this to bypass client validation //need this to bypass client validation
@ -102,20 +98,4 @@ class MoodleQuickForm_submit extends HTML_QuickForm_submit {
$this->_flagFrozen = true; $this->_flagFrozen = true;
} }
/**
* Returns HTML for this form element.
*
* @return string
*/
function toHtml(){
global $PAGE;
$options = array(
'submitid' => $this->getAttribute('id'),
'formid' => $this->_formid,
);
$str = parent::toHtml();
$module = array('name'=>'form_submit', 'fullpath'=>'/lib/form/submit.js');
$PAGE->requires->js_init_call('M.form_submit.init', array($options), true, $module);
return $str;
}
} }

2
lib/formslib.php
View file

@ -2096,7 +2096,6 @@ class MoodleQuickForm extends HTML_QuickForm_DHTMLRulesTableless {
//<![CDATA[ //<![CDATA[
var skipClientValidation = false; var skipClientValidation = false;
var containsErrors = false;
function qf_errorHandler(element, _qfMsg) { function qf_errorHandler(element, _qfMsg) {
div = element.parentNode; div = element.parentNode;
@ -2205,7 +2204,6 @@ function validate_' . $this->_formName . '(frm) {
var frm = document.getElementById(\''. $this->_attributes['id'] .'\') var frm = document.getElementById(\''. $this->_attributes['id'] .'\')
var first_focus = false; var first_focus = false;
' . $validateJS . '; ' . $validateJS . ';
containsErrors = !ret;
return ret; return ret;
} }
//]]> //]]>