moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix small bug only reproduced in tests about changing field names and

Browse source 
xmldb_field object becoming modified. Novice OOP bug :-(

Merged from MODLE_18_STABLE
This commit is contained in:
stronk7 2007-03-15 20:02:17 +00:00
parent bdb794843a
commit c7a311b550
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/xmldb/classes/generators/mysql/mysql.class.php
View file

@ -203,11 +203,14 @@ class XMLDBmysql extends XMLDBGenerator {
$results = array(); //Array where all the sentences will be stored
/// Need a clone of xmldb_field to perform the change leaving original unmodified
$xmldb_field_clone = clone($xmldb_field);
/// Change the name of the field to perform the change
$xmldb_field->setName($xmldb_field->getName() . ' ' . $newname);
$xmldb_field_clone->setName($xmldb_field_clone->getName() . ' ' . $newname);
$results[] = 'ALTER TABLE ' . $this->getTableName($xmldb_table) . ' CHANGE ' .
$this->getFieldSQL($xmldb_field);
$this->getFieldSQL($xmldb_field_clone);
return $results;
}