moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

unit tests: MDL-22175 Still more improvements unit test failure display.

Browse source 
Thanks to Eloy for suggesting these improvements:
1. We display debuginfo if it is there.
2. If the exception refers to a missing lang string, we output as much
information as we have.
This commit is contained in:
Tim Hunt 2010-04-26 15:25:56 +00:00
parent 5fbd8c0b07
commit c8a9f066f7
1 changed files with 39 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

42
admin/report/unittest/ex_reporter.php
View file

@ -92,21 +92,49 @@ class ExHtmlReporter extends HtmlReporter {
function paintException($exception) { function paintException($exception) {
// Explicitly call grandparent, not parent::paintException. // Explicitly call grandparent, not parent::paintException.
SimpleScorer::paintException($exception); SimpleScorer::paintException($exception);
if (is_a($exception, 'moodle_exception') &&
!get_string_manager()->string_exists($exception->errorcode, $exception->module)) {
$exceptionmessage = 'Exception with missing language string {' .
$exception->errorcode . '} from language file {' . $exception->module . '}';
if (!empty($exception->a)) {
if (is_string($exception->a)) {
$data = $exception->a;
} else {
$data = array();
foreach ((array)$exception->a as $name => $value) {
$data[] = $name . ' => [' . $value . ']';
}
$data = implode(', ', $data);
}
$exceptionmessage .= ' with data {' . $data . '}';
}
} else {
$exceptionmessage = $exception->getMessage();
}
$message = 'Unexpected exception of type [' . get_class($exception) . $message = 'Unexpected exception of type [' . get_class($exception) .
'] with message ['. $exception->getMessage() . '] with message ['. $exceptionmessage .
'] in ['. $exception->getFile() . '] in ['. $exception->getFile() .
' line ' . $exception->getLine() . ']'; ' line ' . $exception->getLine() . ']';
$this->_paintPassFail('exception', $message, $exception->getTrace()); $debuginfo = null;
if (!empty($exception->debuginfo)) {
$debuginfo = $exception->debuginfo;
}
$this->_paintPassFail('exception', $message, $exception->getTrace(), $debuginfo);
} }
/** /**
* Private method. Used by printPass/Fail/Skip/Error. * Private method. Used by printPass/Fail/Skip/Error.
*/ */
function _paintPassFail($passorfail, $message, $stacktrace = null) { function _paintPassFail($passorfail, $message, $stacktrace = null, $debuginfo = null) {
global $FULLME, $CFG, $OUTPUT; global $FULLME, $CFG, $OUTPUT;
echo $OUTPUT->box_start($passorfail . ' generalbox '); echo $OUTPUT->box_start($passorfail . ' generalbox ');
$url = $this->_htmlEntities($this->_stripParameterFromUrl($FULLME, 'path')); $url = $this->_htmlEntities($this->_stripParameterFromUrl($FULLME, 'path'));
echo '<b class="', $passorfail, '">', $this->get_string($passorfail), '</b>: '; echo '<b class="', $passorfail, '">', $this->get_string($passorfail), '</b>: ';
$breadcrumb = $this->getTestList(); $breadcrumb = $this->getTestList();
@ -121,7 +149,14 @@ class ExHtmlReporter extends HtmlReporter {
} }
echo "<a href=\"{$url}path=$folder$file\" title=\"$this->strrunonlyfile\">$file</a>"; echo "<a href=\"{$url}path=$folder$file\" title=\"$this->strrunonlyfile\">$file</a>";
echo $this->strseparator, implode($this->strseparator, $breadcrumb); echo $this->strseparator, implode($this->strseparator, $breadcrumb);
echo '<br />', $this->_htmlEntities($message), "\n\n"; echo '<br />', $this->_htmlEntities($message), "\n\n";
if (!empty($debuginfo)) {
print_object('Debug info:');
print_object($debuginfo);
}
if ($stacktrace) { if ($stacktrace) {
$dotsadded = false; $dotsadded = false;
$interestinglines = 0; $interestinglines = 0;
@ -142,6 +177,7 @@ class ExHtmlReporter extends HtmlReporter {
echo '<div class="notifytiny">' . format_backtrace($filteredstacktrace) . "</div>\n\n"; echo '<div class="notifytiny">' . format_backtrace($filteredstacktrace) . "</div>\n\n";
} }
} }
echo $OUTPUT->box_end(); echo $OUTPUT->box_end();
flush(); flush();
} }