mirror of
https://github.com/moodle/moodle.git
synced 2025-08-04 16:36:37 +02:00
MDL-18403: Completion system can cause problems if grade completion is somehow enabled when completion is set to manual
This commit is contained in:
parent
27eef3bb33
commit
ca6b2d6801
1 changed files with 4 additions and 3 deletions
|
@ -661,10 +661,11 @@ WHERE
|
|||
}
|
||||
|
||||
public function inform_grade_changed($cm, $item, $grade, $deleted) {
|
||||
// Bail out now if completion is not enabled for course-module, grade
|
||||
// is not used to compute completion, or this is a different numbered
|
||||
// grade
|
||||
// Bail out now if completion is not enabled for course-module, it is enabled
|
||||
// but is set to manual, grade is not used to compute completion, or this
|
||||
// is a different numbered grade
|
||||
if (!$this->is_enabled($cm) ||
|
||||
$cm->completion == COMPLETION_TRACKING_MANUAL ||
|
||||
is_null($cm->completiongradeitemnumber) ||
|
||||
$item->itemnumber != $cm->completiongradeitemnumber) {
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue