moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-18403: Completion system can cause problems if grade completion is somehow enabled when completion is set to manual

Browse source
This commit is contained in:
sam_marshall 2009-02-27 14:35:05 +00:00
parent 27eef3bb33
commit ca6b2d6801
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/completionlib.php
View file

@ -661,10 +661,11 @@ WHERE
} }
public function inform_grade_changed($cm, $item, $grade, $deleted) { public function inform_grade_changed($cm, $item, $grade, $deleted) {
// Bail out now if completion is not enabled for course-module, grade // Bail out now if completion is not enabled for course-module, it is enabled
// is not used to compute completion, or this is a different numbered // but is set to manual, grade is not used to compute completion, or this
// grade // is a different numbered grade
if (!$this->is_enabled($cm) || if (!$this->is_enabled($cm) ||
$cm->completion == COMPLETION_TRACKING_MANUAL ||
is_null($cm->completiongradeitemnumber) || is_null($cm->completiongradeitemnumber) ||
$item->itemnumber != $cm->completiongradeitemnumber) { $item->itemnumber != $cm->completiongradeitemnumber) {