Merge branch 'MDL-67296-master' of git://github.com/vmdef/moodle

lib/tests/fixtures/testable_core_h5p.php

@@ -0,0 +1,102 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Fixture for testing the functionality of core_h5p.
+ *
+ * @package     core
+ * @subpackage  fixtures
+ * @category    test
+ * @copyright   2019 Victor Deniz <victor@moodle.com>
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace core_h5p;
+
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * H5P factory class stub for testing purposes.
+ *
+ * This class extends the real one to return the H5P core class stub.
+ *
+ * @copyright  2019 Victor Deniz <victor@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class h5p_test_factory extends factory {
+    /**
+     * Returns an instance of the \core_h5p\core stub class.
+     *
+     * @return core_h5p\core
+     */
+    public function get_core(): core {
+        if ($this->core === null ) {
+            $fs = new file_storage();
+            $language = framework::get_language();
+            $context = \context_system::instance();
+
+            $url = \moodle_url::make_pluginfile_url($context->id, 'core_h5p', '', null,
+                '', '')->out();
+
+            $this->core = new h5p_test_core($this->get_framework(), $fs, $url, $language, true);
+        }
+
+        return $this->core;
+    }
+}
+
+/**
+ * H5P core class stub for testing purposes.
+ *
+ * Modifies get_api_endpoint method to use local URLs.
+ *
+ * @copyright   2019 Victor Deniz <victor@moodle.com>
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class h5p_test_core extends core {
+    /** @var $endpoint Endpoint URL for testing H5P API */
+    protected $endpoint;
+
+    /**
+     * Set the endpoint URL
+     *
+     * @param string $url Endpoint URL
+     * @return void
+     */
+    public function set_endpoint($url): void {
+        $this->endpoint = $url;
+    }
+
+    /**
+     * Get the URL of the test endpoints instead of the H5P ones.
+     *
+     * If $library is null, moodle_url is the endpoint of the json test file with the H5P content types definition. If library is
+     * the machine name of a content type, moodle_url is the test URL for downloading the content type file.
+     *
+     * @param string|null $library The filename of the H5P content type file in external.
+     * @return \moodle_url The moodle_url of the file in external.
+     */
+    public function get_api_endpoint(?string $library): \moodle_url {
+
+        if ($library) {
+            $h5purl = $this->endpoint . '/' . $library . '.h5p';
+        } else {
+            $h5purl = $h5purl = $this->endpoint . '/h5pcontenttypes.json';
+        }
+
+        return new \moodle_url($h5purl);
+    }
+}

lib/tests/h5p_get_content_types_task_test.php

@@ -22,6 +22,9 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use core_h5p\autoloader;
+use core_h5p\h5p_test_factory;
+
 defined('MOODLE_INTERNAL') || die();
 
 /**
@@ -35,12 +38,22 @@ defined('MOODLE_INTERNAL') || die();
  */
 class h5p_get_content_types_task_test extends advanced_testcase {
 
+    protected function setup() {
+        global $CFG;
+        parent::setUp();
+
+        autoloader::register();
+
+        require_once($CFG->libdir . '/tests/fixtures/testable_core_h5p.php');
+    }
+
     /**
      * Test task execution
      *
      * return void
      */
     public function test_task_execution(): void {
+
         if (!PHPUNIT_LONGTEST) {
             $this->markTestSkipped('PHPUNIT_LONGTEST is not defined');
         }
@@ -51,10 +64,23 @@ class h5p_get_content_types_task_test extends advanced_testcase {
         $generator = \testing_util::get_data_generator();
         $h5pgenerator = $generator->get_plugin_generator('core_h5p');
 
-        $h5pgenerator->create_content_types(2);
+        $factory = new h5p_test_factory();
+        $core = $factory->get_core();
+        $core->set_endpoint($this->getExternalTestFileUrl(''));
+        $contenttypespending = ['H5P.Accordion'];
 
-        $task = new \core\task\h5p_get_content_types_task();
-        $task->execute();
-        $this->expectOutputRegex('/2 new content types/');
+        $h5pgenerator->create_content_types( $contenttypespending, $core);
+
+        // Mock implementation of \core\task\h5p_get_content_types_task::get_core to avoid external systems.
+        $mocktask = $this->getMockBuilder(\core\task\h5p_get_content_types_task::class)
+            ->setMethods(['get_core'])
+            ->getMock();
+
+        $mocktask->expects($this->any())
+            ->method('get_core')
+            ->willReturn($core);
+
+        $mocktask->execute();
+        $this->expectOutputRegex('/1 new content types/');
     }
 }