moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

minor fix

Browse source
This commit is contained in:
nicolasconnault 2007-07-10 18:41:28 +00:00
parent c86caae78a
commit cd20e11c28
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
grade/report/grader/index.php
View file

@ -211,8 +211,6 @@ if ($perpageurl = optional_param('perpage', 0, PARAM_INT)) {
$perpage = $perpageurl; $perpage = $perpageurl;
} }
/// setting up groups
// Prepare language strings // Prepare language strings
$strsortasc = get_string('sortasc', 'grades'); $strsortasc = get_string('sortasc', 'grades');
$strsortdesc = get_string('sortdesc', 'grades'); $strsortdesc = get_string('sortdesc', 'grades');
@ -222,6 +220,7 @@ $baseurl = 'report.php?id='.$courseid.'&perpage='.$perpage.'&report=grad
// base url for paging // base url for paging
$pbarurl = 'report.php?id='.$courseid.'&perpage='.$perpage.'&report=grader&'; $pbarurl = 'report.php?id='.$courseid.'&perpage='.$perpage.'&report=grader&';
/// setting up groups
$groupsql = ''; $groupsql = '';
$groupwheresql = ''; $groupwheresql = '';
$group_selector = null; $group_selector = null;
@ -631,13 +630,15 @@ foreach ($users as $userid => $user) {
} }
} }
// Prepare icons for when quickgrading or quickfeedback are switched off
$icons_html = '<div class="grade_icons">'; $icons_html = '<div class="grade_icons">';
// If quickgrading is off, print an edit icon
if (!$quickgrading) { if (!$quickgrading) {
// If quickgrading is off, print an edit icon
$icons_html .= grade_get_icons($element, $gtree, array('edit')); $icons_html .= grade_get_icons($element, $gtree, array('edit'));
} }
// If quickfeedback is on, print an input element
if ($showfeedback && $quickfeedback) { if ($showfeedback && $quickfeedback) {
$studentshtml .= '<input size="6" type="text" name="feedback_'.$userid.'_'.$item->id.'" value="'. s($grade->feedback) . '"/>'; $studentshtml .= '<input size="6" type="text" name="feedback_'.$userid.'_'.$item->id.'" value="'. s($grade->feedback) . '"/>';
@ -650,7 +651,10 @@ foreach ($users as $userid => $user) {
} }
$icons_html .= '</div>'; $icons_html .= '</div>';
$studentshtml .= $icons_html;
if (!$quickfeedback || !$quickgrading) {
$studentshtml .= $icons_html;
}
} else { } else {
// finalgrades[$userid][$itemid] could be null because of the outer join // finalgrades[$userid][$itemid] could be null because of the outer join
@ -794,7 +798,7 @@ if ($USER->gradeediting) {
echo $reporthtml; echo $reporthtml;
// print submit button // print submit button
if ($USER->gradeediting) { if ($USER->gradeediting && ($quickfeedback || $quickgrading)) {
echo '<div class="submit"><input type="submit" value="'.get_string('update').'" /></div>'; echo '<div class="submit"><input type="submit" value="'.get_string('update').'" /></div>';
echo '</div></form>'; echo '</div></form>';
} }